commit 6df55cac1a2c4441a70d15875ab22530251509ce
author Matt Caswell <matt@openssl.org> Fri Jan 20 13:53:38 2017 +0000
committer Matt Caswell <matt@openssl.org> Mon Jan 30 10:18:23 2017 +0000
tree 42af348468be4fea22c5d532d4d7bcc85ac60f5b
parent 9ac6244b575486dcdbd600c36da78776fde32e11

Ensure the al variable is properly ininitialised in all code paths

Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/2259)

ssl/statem/statem_clnt.c

diff --git a/ssl/statem/statem_clnt.c b/ssl/statem/statem_clnt.c
index cd87194..53e16f8 100644
--- a/ssl/statem/statem_clnt.c
+++ b/ssl/statem/statem_clnt.c
@@ -2210,7 +2210,7 @@
 
 MSG_PROCESS_RETURN tls_process_new_session_ticket(SSL *s, PACKET *pkt)
 {
-    int al;
+    int al = SSL_AD_DECODE_ERROR;
     unsigned int ticklen;
     unsigned long ticket_lifetime_hint, age_add = 0;
     unsigned int sess_len;
@@ -2222,7 +2222,6 @@
         || (!SSL_IS_TLS13(s) && PACKET_remaining(pkt) != ticklen)
         || (SSL_IS_TLS13(s) && (ticklen == 0
                                 || PACKET_remaining(pkt) < ticklen))) {
-        al = SSL_AD_DECODE_ERROR;
         SSLerr(SSL_F_TLS_PROCESS_NEW_SESSION_TICKET, SSL_R_LENGTH_MISMATCH);
         goto f_err;
     }