commit 7f6dfa19dfbd1d009bf3ab36805b8d132d4ecd56
author Matt Caswell <matt@openssl.org> Wed Apr 18 14:22:36 2018 +0100
committer Matt Caswell <matt@openssl.org> Thu Apr 19 08:53:40 2018 +0100
tree d0092b5af419a32aeccefee5d9e994965a8551ca
parent 1c705121af8a0f8095d7cb36419e1166f42cc1e6

Add a test for a NULL X509_STORE in X509_STORE_CTX_init

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/6001)

test/verify_extra_test.c

diff --git a/test/verify_extra_test.c b/test/verify_extra_test.c
index 83d93cd..5d46542 100644
--- a/test/verify_extra_test.c
+++ b/test/verify_extra_test.c
@@ -138,6 +138,43 @@
     return ret;
 }
 
+static int test_store_ctx(void)
+{
+    X509_STORE_CTX *sctx = NULL;
+    X509 *x = NULL;
+    BIO *bio = NULL;
+    int testresult = 0, ret;
+
+    bio = BIO_new_file(bad_f, "r");
+    if (bio == NULL)
+        goto err;
+
+    x = PEM_read_bio_X509(bio, NULL, 0, NULL);
+    if (x == NULL)
+        goto err;
+
+    sctx = X509_STORE_CTX_new();
+    if (sctx == NULL)
+        goto err;
+
+    if (!X509_STORE_CTX_init(sctx, NULL, x, NULL))
+        goto err;
+
+    /* Verifying a cert where we have no trusted certs should fail */
+    ret = X509_verify_cert(sctx);
+
+    if (ret == 0) {
+        /* This is the result we were expecting: Test passed */
+        testresult = 1;
+    }
+
+ err:
+    X509_STORE_CTX_free(sctx);
+    X509_free(x);
+    BIO_free(bio);
+    return testresult;
+}
+
 int setup_tests(void)
 {
     if (!TEST_ptr(roots_f = test_get_argument(0))
@@ -148,5 +185,6 @@
     }
 
     ADD_TEST(test_alt_chains_cert_forgery);
+    ADD_TEST(test_store_ctx);
     return 1;
 }