commit 8e1634ec36c9a125f3aa1c48b743ff864c6fcbd3
author Tatsuhiro Tsujikawa <tatsuhiro.t@gmail.com> Fri Apr 21 22:10:32 2017 +0900
committer Matt Caswell <matt@openssl.org> Wed Apr 26 16:56:37 2017 +0100
tree 3228430919079eaf5c1b0fc9ca1a64b3b8c824ae
parent bf5c84f5d17ed68076ba1faa4a9eaaf4f51e4bf1

Don't treat PACKET_remaining() as boolean

Reviewed-by: Rich Salz <rsalz@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/3244)

ssl/statem/statem_clnt.c

diff --git a/ssl/statem/statem_clnt.c b/ssl/statem/statem_clnt.c
index 0b4931d..a66dd40 100644
--- a/ssl/statem/statem_clnt.c
+++ b/ssl/statem/statem_clnt.c
@@ -1712,9 +1712,9 @@
             if (!tls_collect_extensions(s, &extensions,
                                         SSL_EXT_TLS1_3_CERTIFICATE, &rawexts,
                                         &al, NULL, chainidx == 0)
-                    || !tls_parse_all_extensions(s, SSL_EXT_TLS1_3_CERTIFICATE,
-                                                 rawexts, x, chainidx, &al,
-                                                 !PACKET_remaining(pkt))) {
+                || !tls_parse_all_extensions(s, SSL_EXT_TLS1_3_CERTIFICATE,
+                                             rawexts, x, chainidx, &al,
+                                             PACKET_remaining(pkt) == 0)) {
                 OPENSSL_free(rawexts);
                 goto f_err;
             }