commit 8e7677aeacea0657846df444553680fdd3391f8c
author Matt Caswell <matt@openssl.org> Mon Nov 27 11:34:05 2017 +0000
committer Matt Caswell <matt@openssl.org> Mon Dec 04 13:31:48 2017 +0000
tree 0adeef9c630d29941ad924046d8b52a7c0d0fe10
parent 8e02e73d80d44d31fbfbb757c8cbd5dad7cd311e

Update an error reason code to be ERR_R_SHOULD_NOT_HAVE_BEEN_CALLED

The most likely explanation for us ending up at this point in the code
is that we were called by the user application incorrectly - so use an
appropriate error code.

Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/4778)

ssl/statem/statem.c

diff --git a/ssl/statem/statem.c b/ssl/statem/statem.c
index fe34841..0cacc4a 100644
--- a/ssl/statem/statem.c
+++ b/ssl/statem/statem.c
@@ -443,7 +443,7 @@
         } else {
             /* Error */
             check_fatal(s, SSL_F_STATE_MACHINE);
-            SSLerr(SSL_F_STATE_MACHINE, ERR_R_INTERNAL_ERROR);
+            SSLerr(SSL_F_STATE_MACHINE, ERR_R_SHOULD_NOT_HAVE_BEEN_CALLED);
             goto end;
         }
     }