commit 9b0f76e12f8de88c8709fe53e85f887485ef53f4
author Pauli <ppzgs1@gmail.com> Thu Mar 18 12:54:28 2021 +1000
committer Pauli <ppzgs1@gmail.com> Sat Mar 20 10:08:00 2021 +1000
tree 8407750665228c8962c4a8b4bec2b6cf890484fd
parent 015b221a5fd777e1ab808ec23f03df238eaf8429

test: fix coverity 1470559: resource leak

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14596)

test/moduleloadtest.c

diff --git a/test/moduleloadtest.c b/test/moduleloadtest.c
index 915343f..2ad0dac 100644
--- a/test/moduleloadtest.c
+++ b/test/moduleloadtest.c
@@ -23,10 +23,14 @@
 #ifdef SD_INIT
     SD sd = SD_INIT;
     SD_SYM sym;
+    int ret;
 
-    return sd_load(path, &sd, SD_MODULE)
-        && (symbol == NULL || sd_sym(sd, symbol, &sym))
-        && sd_close(sd);
+    if (!sd_load(path, &sd, SD_MODULE))
+        return 0;
+    ret = symbol == NULL || sd_sym(sd, symbol, &sym);
+    if (!sd_close(sd))
+        ret = 0;
+    return ret;
 #else
     fprintf(stderr, "No dynamic loader\n");
     return 0;