commit a71edf3ba275b946224b5bcded0a8ecfce1855c0
author Matt Caswell <matt@openssl.org> Fri Oct 30 10:05:53 2015 +0000
committer Matt Caswell <matt@openssl.org> Mon Nov 09 22:48:41 2015 +0000
tree 85257ad90882fc4d8d8f73cd91a03b7cc476b9d2
parent 3457e7a087a643cb65d67d9d72ec5983a02f5dfe

Standardise our style for checking malloc failures

if we have a malloc |x = OPENSSL_malloc(...)| sometimes we check |x|
for NULL and sometimes we treat it as a boolean |if(!x) ...|. Standardise
the approach in libssl.

Reviewed-by: Kurt Roeckx <kurt@openssl.org>

ssl/d1_lib.c

diff --git a/ssl/d1_lib.c b/ssl/d1_lib.c
index b865ad4..6e70c56 100644
--- a/ssl/d1_lib.c
+++ b/ssl/d1_lib.c
@@ -155,7 +155,7 @@
     d1->link_mtu = 0;
     d1->mtu = 0;
 
-    if (!d1->buffered_messages || !d1->sent_messages) {
+    if (d1->buffered_messages == NULL || d1->sent_messages == NULL) {
         pqueue_free(d1->buffered_messages);
         pqueue_free(d1->sent_messages);
         OPENSSL_free(d1);