commit ad7cb0bf5cb9b014d34327cb35ecdd609a3d4dd4
author Benjamin Kaduk <bkaduk@akamai.com> Fri Feb 19 13:46:49 2021 -0800
committer Richard Levitte <levitte@openssl.org> Sat Feb 27 16:14:09 2021 +0100
tree 67973d51dbb3dcf5529fff05456d36a606579bcf
parent c0ff1932e446621f43cd607371b7d265370d4bc6

test_ecpub: verify returned length after encoding

Save the length we got from querying how much space was needed, and
check that the actual encoding call returned the same length.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14291)

test/evp_extra_test.c

diff --git a/test/evp_extra_test.c b/test/evp_extra_test.c
index 487767f..844c8da 100644
--- a/test/evp_extra_test.c
+++ b/test/evp_extra_test.c
@@ -2423,7 +2423,7 @@
 
 static int test_ecpub(int idx)
 {
-    int ret = 0, len;
+    int ret = 0, len, savelen;
     int nid;
     unsigned char buf[1024];
     unsigned char *p;
@@ -2439,12 +2439,14 @@
         || !TEST_true(EVP_PKEY_keygen(ctx, &pkey)))
         goto done;
     len = i2d_PublicKey(pkey, NULL);
+    savelen = len;
     if (!TEST_int_ge(len, 1)
         || !TEST_int_lt(len, 1024))
         goto done;
     p = buf;
     len = i2d_PublicKey(pkey, &p);
-    if (!TEST_int_ge(len, 1))
+    if (!TEST_int_ge(len, 1)
+            || !TEST_int_eq(len, savelen))
         goto done;
 
     ret = 1;