commit b4faea50c35d92a67d1369355b49cc3efba78406
author Rich Salz <rsalz@akamai.com> Fri May 01 23:10:31 2015 -0400
committer Rich Salz <rsalz@openssl.org> Mon May 04 15:00:13 2015 -0400
tree cfebea69d625f936c9fd7281f1fa3eaa2fa38834
parent 8920a7cd04f43b1a090d0b0a8c9e16b94c6898d4

Use safer sizeof variant in malloc

For a local variable:
        TYPE *p;
Allocations like this are "risky":
        p = OPENSSL_malloc(sizeof(TYPE));
if the type of p changes, and the malloc call isn't updated, you
could get memory corruption.  Instead do this:
        p = OPENSSL_malloc(sizeof(*p));
Also fixed a few memset() calls that I noticed while doing this.

Reviewed-by: Richard Levitte <levitte@openssl.org>

apps/ecparam.c

diff --git a/apps/ecparam.c b/apps/ecparam.c
index dd0e8f5..5ceaec7 100644
--- a/apps/ecparam.c
+++ b/apps/ecparam.c
@@ -232,7 +232,7 @@
         size_t crv_len = EC_get_builtin_curves(NULL, 0);
         size_t n;
 
-        curves = app_malloc((int)(sizeof *curves * crv_len), "list curves");
+        curves = app_malloc((int)sizeof(*curves) * crv_len, "list curves");
         if (!EC_get_builtin_curves(curves, crv_len)) {
             OPENSSL_free(curves);
             goto end;