commit c9de4a20fa21101208cf311c5437d9c358ba1f07
author Matt Caswell <matt@openssl.org> Thu Oct 22 15:02:14 2015 +0100
committer Matt Caswell <matt@openssl.org> Fri Oct 30 08:39:47 2015 +0000
tree f2b0987b34745b78bb18e57eb655a9560a360e30
parent d13dd4beb4674689c7a46450dbb8bae9af24d510

Fix empty NewSessionTicket processing

Rebasing the state machine code introduced a problem with empty
NewSessionTicket processing. The return value from the
tls_process_new_session_ticket() is supposed to be an enum, but a bare
integer was being used. Unfortunately this is valid C so the compiler
doesn't pick it up.

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>

ssl/statem/statem_clnt.c

diff --git a/ssl/statem/statem_clnt.c b/ssl/statem/statem_clnt.c
index dbba36b..d0c6b12 100644
--- a/ssl/statem/statem_clnt.c
+++ b/ssl/statem/statem_clnt.c
@@ -2184,7 +2184,7 @@
 
     /* Server is allowed to change its mind and send an empty ticket. */
     if (ticklen == 0)
-        return 1;
+        return MSG_PROCESS_CONTINUE_READING;
 
     if (s->session->session_id_length > 0) {
         int i = s->session_ctx->session_cache_mode;