APPS: Improve diagnostics on missing/extra args and unknown cipher/digest
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/16450)
diff --git a/apps/asn1parse.c b/apps/asn1parse.c
index f0bfd1d..b456f13 100644
--- a/apps/asn1parse.c
+++ b/apps/asn1parse.c
@@ -159,8 +159,7 @@
}
/* No extra args. */
- argc = opt_num_rest();
- if (argc != 0)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
if (oidfile != NULL) {
diff --git a/apps/ciphers.c b/apps/ciphers.c
index 9c49422..dcf0d3f 100644
--- a/apps/ciphers.c
+++ b/apps/ciphers.c
@@ -174,10 +174,9 @@
/* Optional arg is cipher name. */
argv = opt_rest();
- argc = opt_num_rest();
- if (argc == 1)
+ if (opt_num_rest() == 1)
ciphers = argv[0];
- else if (argc != 0)
+ else if (!opt_check_rest_arg(NULL))
goto opthelp;
if (convert != NULL) {
diff --git a/apps/cmp.c b/apps/cmp.c
index f646e3f..5056d84 100644
--- a/apps/cmp.c
+++ b/apps/cmp.c
@@ -2552,9 +2552,7 @@
}
/* No extra args. */
- argc = opt_num_rest();
- argv = opt_rest();
- if (argc != 0)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
return 1;
}
diff --git a/apps/cms.c b/apps/cms.c
index 76c7896..18671fd 100644
--- a/apps/cms.c
+++ b/apps/cms.c
@@ -697,10 +697,8 @@
if (!opt_md(digestname, &sign_md))
goto end;
}
- if (ciphername != NULL) {
- if (!opt_cipher_any(ciphername, &cipher))
- goto end;
- }
+ if (!opt_cipher_any(ciphername, &cipher))
+ goto end;
if (wrapname != NULL) {
if (!opt_cipher_any(wrapname, &wrap_cipher))
goto end;
diff --git a/apps/crl.c b/apps/crl.c
index 2158a10..8d353ff 100644
--- a/apps/crl.c
+++ b/apps/crl.c
@@ -209,14 +209,11 @@
}
/* No remaining args. */
- argc = opt_num_rest();
- if (argc != 0)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
- if (digestname != NULL) {
- if (!opt_md(digestname, &digest))
- goto opthelp;
- }
+ if (!opt_md(digestname, &digest))
+ goto opthelp;
x = load_crl(infile, informat, 1, "CRL");
if (x == NULL)
goto end;
diff --git a/apps/crl2pkcs7.c b/apps/crl2pkcs7.c
index fe59e65..681c602 100644
--- a/apps/crl2pkcs7.c
+++ b/apps/crl2pkcs7.c
@@ -104,8 +104,7 @@
}
/* No remaining args. */
- argc = opt_num_rest();
- if (argc != 0)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
if (!nocrl) {
diff --git a/apps/dhparam.c b/apps/dhparam.c
index 0e90698..9fe0eed 100644
--- a/apps/dhparam.c
+++ b/apps/dhparam.c
@@ -155,7 +155,7 @@
if (argc == 1) {
if (!opt_int(argv[0], &num) || num <= 0)
goto opthelp;
- } else if (argc != 0) {
+ } else if (!opt_check_rest_arg(NULL)) {
goto opthelp;
}
if (!app_RAND_load())
diff --git a/apps/dsa.c b/apps/dsa.c
index 51c0284..9605ed8 100644
--- a/apps/dsa.c
+++ b/apps/dsa.c
@@ -161,14 +161,11 @@
}
/* No extra args. */
- argc = opt_num_rest();
- if (argc != 0)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
- if (ciphername != NULL) {
- if (!opt_cipher(ciphername, &enc))
- goto end;
- }
+ if (!opt_cipher(ciphername, &enc))
+ goto end;
private = pubin || pubout ? 0 : 1;
if (text && !pubin)
private = 1;
diff --git a/apps/dsaparam.c b/apps/dsaparam.c
index 8025b8b..08f9123 100644
--- a/apps/dsaparam.c
+++ b/apps/dsaparam.c
@@ -133,7 +133,7 @@
if (argc == 1) {
if (!opt_int(argv[0], &num) || num < 0)
goto opthelp;
- } else if (argc != 0) {
+ } else if (!opt_check_rest_arg(NULL)) {
goto opthelp;
}
if (!app_RAND_load())
diff --git a/apps/ec.c b/apps/ec.c
index dcbef10..4573300 100644
--- a/apps/ec.c
+++ b/apps/ec.c
@@ -157,14 +157,11 @@
}
/* No extra arguments. */
- argc = opt_num_rest();
- if (argc != 0)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
- if (ciphername != NULL) {
- if (!opt_cipher(ciphername, &enc))
- goto opthelp;
- }
+ if (!opt_cipher(ciphername, &enc))
+ goto opthelp;
private = param_out || pubin || pubout ? 0 : 1;
if (text && !pubin)
private = 1;
diff --git a/apps/ecparam.c b/apps/ecparam.c
index 12eed70..9910d8c 100644
--- a/apps/ecparam.c
+++ b/apps/ecparam.c
@@ -186,8 +186,7 @@
}
/* No extra args. */
- argc = opt_num_rest();
- if (argc != 0)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
if (!app_RAND_load())
diff --git a/apps/enc.c b/apps/enc.c
index 3dd6098..e71453c 100644
--- a/apps/enc.c
+++ b/apps/enc.c
@@ -289,17 +289,14 @@
}
/* No extra arguments. */
- argc = opt_num_rest();
- if (argc != 0)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
if (!app_RAND_load())
goto end;
/* Get the cipher name, either from progname (if set) or flag. */
- if (ciphername != NULL) {
- if (!opt_cipher(ciphername, &cipher))
- goto opthelp;
- }
+ if (!opt_cipher(ciphername, &cipher))
+ goto opthelp;
if (digestname != NULL) {
if (!opt_md(digestname, &dgst))
goto opthelp;
diff --git a/apps/fipsinstall.c b/apps/fipsinstall.c
index 3636311..5af0070 100644
--- a/apps/fipsinstall.c
+++ b/apps/fipsinstall.c
@@ -382,9 +382,12 @@
}
/* No extra arguments. */
- argc = opt_num_rest();
- if (argc != 0 || (verify && in_fname == NULL))
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
+ if (verify && in_fname == NULL) {
+ BIO_printf(bio_err, "Missing -in option for -verify\n");
+ goto opthelp;
+ }
if (parent_config != NULL) {
/* Test that a parent config can load the module */
diff --git a/apps/gendsa.c b/apps/gendsa.c
index e5c9bc2..b9bc2f5 100644
--- a/apps/gendsa.c
+++ b/apps/gendsa.c
@@ -101,19 +101,16 @@
}
/* One argument, the params file. */
- argc = opt_num_rest();
- argv = opt_rest();
- if (argc != 1)
+ if (!opt_check_rest_arg("params file"))
goto opthelp;
+ argv = opt_rest();
dsaparams = argv[0];
if (!app_RAND_load())
goto end;
- if (ciphername != NULL) {
- if (!opt_cipher(ciphername, &enc))
- goto end;
- }
+ if (!opt_cipher(ciphername, &enc))
+ goto end;
private = 1;
if (!app_passwd(NULL, passoutarg, NULL, &passout)) {
diff --git a/apps/genpkey.c b/apps/genpkey.c
index d00754e..7f70a6b 100644
--- a/apps/genpkey.c
+++ b/apps/genpkey.c
@@ -139,8 +139,7 @@
}
/* No extra arguments. */
- argc = opt_num_rest();
- if (argc != 0)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
/* Fetch cipher, etc. */
@@ -163,9 +162,12 @@
goto end;
}
}
- if (ciphername != NULL)
- if (!opt_cipher(ciphername, &cipher) || do_param == 1)
- goto opthelp;
+ if (!opt_cipher(ciphername, &cipher))
+ goto opthelp;
+ if (ciphername != NULL && do_param == 1) {
+ BIO_printf(bio_err, "Cannot use cipher with -genparam option\n");
+ goto opthelp;
+ }
private = do_param ? 0 : 1;
diff --git a/apps/genrsa.c b/apps/genrsa.c
index e709ea3..1a6c673 100644
--- a/apps/genrsa.c
+++ b/apps/genrsa.c
@@ -157,8 +157,7 @@
"Warning: It is not recommended to use more than %d bit for RSA keys.\n"
" Your key size is %d! Larger key size may behave not as expected.\n",
OPENSSL_RSA_MAX_MODULUS_BITS, num);
- } else if (argc > 0) {
- BIO_printf(bio_err, "Extra arguments given.\n");
+ } else if (!opt_check_rest_arg(NULL)) {
goto opthelp;
}
@@ -166,10 +165,8 @@
goto end;
private = 1;
- if (ciphername != NULL) {
- if (!opt_cipher(ciphername, &enc))
- goto end;
- }
+ if (!opt_cipher(ciphername, &enc))
+ goto end;
if (!app_passwd(NULL, passoutarg, NULL, &passout)) {
BIO_printf(bio_err, "Error getting password\n");
goto end;
diff --git a/apps/include/opt.h b/apps/include/opt.h
index 4f83a0e..9493901 100644
--- a/apps/include/opt.h
+++ b/apps/include/opt.h
@@ -368,6 +368,7 @@
int opt_cipher(const char *name, EVP_CIPHER **cipherp);
int opt_cipher_any(const char *name, EVP_CIPHER **cipherp);
int opt_cipher_silent(const char *name, EVP_CIPHER **cipherp);
+int opt_check_md(const char *name);
int opt_md(const char *name, EVP_MD **mdp);
int opt_md_silent(const char *name, EVP_MD **mdp);
@@ -392,6 +393,7 @@
char **opt_rest(void);
int opt_num_rest(void);
+int opt_check_rest_arg(const char *expected);
/* Returns non-zero if legacy paths are still available */
int opt_legacy_okay(void);
diff --git a/apps/info.c b/apps/info.c
index c686036..befc62d 100644
--- a/apps/info.c
+++ b/apps/info.c
@@ -86,7 +86,7 @@
break;
}
}
- if (opt_num_rest() != 0)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
if (dirty > 1) {
BIO_printf(bio_err, "%s: Only one item allowed\n", prog);
diff --git a/apps/lib/opt.c b/apps/lib/opt.c
index 1573679..3925ec9 100644
--- a/apps/lib/opt.c
+++ b/apps/lib/opt.c
@@ -399,8 +399,10 @@
{
int ret;
+ if (name == NULL)
+ return 1;
if ((ret = opt_cipher_silent(name, cipherp)) == 0)
- opt_printf_stderr("%s: Unknown cipher: %s\n", prog, name);
+ opt_printf_stderr("%s: Unknown option or cipher: %s\n", prog, name);
return ret;
}
@@ -410,6 +412,8 @@
unsigned long int flags;
EVP_CIPHER *c = NULL;
+ if (name == NULL)
+ return 1;
if (opt_cipher_any(name, &c)) {
mode = EVP_CIPHER_get_mode(c);
flags = EVP_CIPHER_get_flags(c);
@@ -454,12 +458,22 @@
{
int ret;
+ if (name == NULL)
+ return 1;
if ((ret = opt_md_silent(name, mdp)) == 0)
- opt_printf_stderr("%s: Unknown option or message digest: %s\n", prog,
- name != NULL ? name : "\"\"");
+ opt_printf_stderr("%s: Unknown option or message digest: %s\n",
+ prog, name);
return ret;
}
+int opt_check_md(const char *name)
+{
+ if (opt_md(name, NULL))
+ return 1;
+ ERR_clear_error();
+ return 0;
+}
+
/* Look through a list of name/value pairs. */
int opt_pair(const char *name, const OPT_PAIR* pairs, int *result)
{
@@ -1013,6 +1027,26 @@
return i;
}
+int opt_check_rest_arg(const char *expected)
+{
+ char *opt = *opt_rest();
+
+ if (opt == NULL || *opt == '\0') {
+ if (expected == NULL)
+ return 1;
+ opt_printf_stderr("%s: Missing argument: %s\n", prog, expected);
+ return 0;
+ } else if (expected != NULL) {
+ return 1;
+ }
+ if (opt_unknown() == NULL)
+ opt_printf_stderr("%s: Extra option: \"%s\"\n", prog, opt);
+ else
+ opt_printf_stderr("%s: Extra (unknown) options: \"%s\" \"%s\"\n",
+ prog, opt_unknown(), opt != NULL ? opt : "");
+ return 0;
+}
+
/* Return a string describing the parameter type. */
static const char *valtype2param(const OPTIONS *o)
{
diff --git a/apps/list.c b/apps/list.c
index 9732d66..30bf2be 100644
--- a/apps/list.c
+++ b/apps/list.c
@@ -1647,7 +1647,7 @@
}
/* No extra arguments. */
- if (opt_num_rest() != 0)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
if (todo.commands)
diff --git a/apps/mac.c b/apps/mac.c
index 08f06be..8bd7ce2 100644
--- a/apps/mac.c
+++ b/apps/mac.c
@@ -137,10 +137,9 @@
}
/* One argument, the MAC name. */
- argc = opt_num_rest();
- argv = opt_rest();
- if (argc != 1)
+ if (!opt_check_rest_arg("MAC name"))
goto opthelp;
+ argv = opt_rest();
mac = EVP_MAC_fetch(app_get0_libctx(), argv[0], app_get0_propq());
if (mac == NULL) {
diff --git a/apps/nseq.c b/apps/nseq.c
index d552437..e66b58d 100644
--- a/apps/nseq.c
+++ b/apps/nseq.c
@@ -73,8 +73,7 @@
}
/* No extra arguments. */
- argc = opt_num_rest();
- if (argc != 0)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
in = bio_open_default(infile, 'r', FORMAT_PEM);
diff --git a/apps/ocsp.c b/apps/ocsp.c
index 841b5f7..b0d030a 100644
--- a/apps/ocsp.c
+++ b/apps/ocsp.c
@@ -535,8 +535,7 @@
}
/* No extra arguments. */
- argc = opt_num_rest();
- if (argc != 0)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
if (trailing_md) {
diff --git a/apps/openssl.c b/apps/openssl.c
index d61acbb..3497d51 100644
--- a/apps/openssl.c
+++ b/apps/openssl.c
@@ -357,7 +357,7 @@
new_argv[2] = NULL;
return do_cmd(prog_init(), 2, new_argv);
}
- if (opt_num_rest() != 0) {
+ if (!opt_check_rest_arg(NULL)) {
BIO_printf(bio_err, "Usage: %s\n", prog);
return 1;
}
diff --git a/apps/pkcs12.c b/apps/pkcs12.c
index acc45c4..65dcdad 100644
--- a/apps/pkcs12.c
+++ b/apps/pkcs12.c
@@ -356,17 +356,14 @@
}
/* No extra arguments. */
- argc = opt_num_rest();
- if (argc != 0)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
if (!app_RAND_load())
goto end;
- if (ciphername != NULL) {
- if (!opt_cipher_any(ciphername, &enc))
- goto opthelp;
- }
+ if (!opt_cipher_any(ciphername, &enc))
+ goto opthelp;
if (export_pkcs12) {
if ((options & INFO) != 0)
WARN_EXPORT("info");
diff --git a/apps/pkcs7.c b/apps/pkcs7.c
index ba11e81..ac2dec1 100644
--- a/apps/pkcs7.c
+++ b/apps/pkcs7.c
@@ -111,8 +111,7 @@
}
/* No extra arguments. */
- argc = opt_num_rest();
- if (argc != 0)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
in = bio_open_default(infile, 'r', informat);
diff --git a/apps/pkcs8.c b/apps/pkcs8.c
index 6b09b90..e393224 100644
--- a/apps/pkcs8.c
+++ b/apps/pkcs8.c
@@ -193,8 +193,7 @@
}
/* No extra arguments. */
- argc = opt_num_rest();
- if (argc != 0)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
private = 1;
diff --git a/apps/pkey.c b/apps/pkey.c
index fb3899b..41a4c29 100644
--- a/apps/pkey.c
+++ b/apps/pkey.c
@@ -171,8 +171,7 @@
}
/* No extra arguments. */
- argc = opt_num_rest();
- if (argc != 0)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
if (text && text_pub)
@@ -190,10 +189,8 @@
private = (!noout && !pubout) || (text && !text_pub);
- if (ciphername != NULL) {
- if (!opt_cipher(ciphername, &cipher))
- goto opthelp;
- }
+ if (!opt_cipher(ciphername, &cipher))
+ goto opthelp;
if (cipher == NULL) {
if (passoutarg != NULL)
BIO_printf(bio_err,
diff --git a/apps/pkeyparam.c b/apps/pkeyparam.c
index 4564734..3722be4 100644
--- a/apps/pkeyparam.c
+++ b/apps/pkeyparam.c
@@ -91,8 +91,7 @@
}
/* No extra arguments. */
- argc = opt_num_rest();
- if (argc != 0)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
in = bio_open_default(infile, 'r', FORMAT_PEM);
diff --git a/apps/pkeyutl.c b/apps/pkeyutl.c
index d7290f7..9e18dfc 100644
--- a/apps/pkeyutl.c
+++ b/apps/pkeyutl.c
@@ -253,8 +253,7 @@
}
/* No extra arguments. */
- argc = opt_num_rest();
- if (argc != 0)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
if (!app_RAND_load())
diff --git a/apps/prime.c b/apps/prime.c
index e269493..190254d 100644
--- a/apps/prime.c
+++ b/apps/prime.c
@@ -83,12 +83,12 @@
}
/* Optional arguments are numbers to check. */
+ if (generate && !opt_check_rest_arg(NULL))
+ goto opthelp;
argc = opt_num_rest();
argv = opt_rest();
- if (generate) {
- if (argc != 0)
- goto opthelp;
- } else if (argc == 0) {
+ if (!generate && argc == 0) {
+ BIO_printf(bio_err, "Missing number (s) to check\n");
goto opthelp;
}
diff --git a/apps/rand.c b/apps/rand.c
index cbf495d..f99c91d 100644
--- a/apps/rand.c
+++ b/apps/rand.c
@@ -95,7 +95,7 @@
if (argc == 1) {
if (!opt_int(argv[0], &num) || num <= 0)
goto opthelp;
- } else if (argc != 0) {
+ } else if (!opt_check_rest_arg(NULL)) {
goto opthelp;
}
diff --git a/apps/req.c b/apps/req.c
index 274f839..36ac493 100644
--- a/apps/req.c
+++ b/apps/req.c
@@ -241,7 +241,6 @@
X509 *new_x509 = NULL, *CAcert = NULL;
X509_REQ *req = NULL;
EVP_CIPHER *cipher = NULL;
- EVP_MD *md = NULL;
int ext_copy = EXT_COPY_UNSET;
BIO *addext_bio = NULL;
char *extsect = NULL;
@@ -473,8 +472,7 @@
}
/* No extra arguments. */
- argc = opt_num_rest();
- if (argc != 0)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
if (!app_RAND_load())
@@ -533,11 +531,8 @@
/* Check that any specified digest is fetchable */
if (digest != NULL) {
- if (!opt_md(digest, &md)) {
- ERR_clear_error();
+ if (!opt_check_md(digest))
goto opthelp;
- }
- EVP_MD_free(md);
} else {
/* No digest specified, default to configuration */
p = NCONF_get_string(req_conf, section, "default_md");
diff --git a/apps/rsa.c b/apps/rsa.c
index 05a091c..fb73173 100644
--- a/apps/rsa.c
+++ b/apps/rsa.c
@@ -217,14 +217,11 @@
}
/* No extra arguments. */
- argc = opt_num_rest();
- if (argc != 0)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
- if (ciphername != NULL) {
- if (!opt_cipher(ciphername, &enc))
- goto opthelp;
- }
+ if (!opt_cipher(ciphername, &enc))
+ goto opthelp;
private = (text && !pubin) || (!pubout && !noout) ? 1 : 0;
if (!app_passwd(passinarg, passoutarg, &passin, &passout)) {
diff --git a/apps/rsautl.c b/apps/rsautl.c
index ae02060..c428bf1 100644
--- a/apps/rsautl.c
+++ b/apps/rsautl.c
@@ -169,8 +169,7 @@
}
/* No extra arguments. */
- argc = opt_num_rest();
- if (argc != 0)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
if (!app_RAND_load())
diff --git a/apps/s_client.c b/apps/s_client.c
index e074849..b905fbd 100644
--- a/apps/s_client.c
+++ b/apps/s_client.c
@@ -1473,8 +1473,7 @@
}
/* Optional argument is connect string if -connect not used. */
- argc = opt_num_rest();
- if (argc == 1) {
+ if (opt_num_rest() == 1) {
/* Don't allow -connect and a separate argument. */
if (connectstr != NULL) {
BIO_printf(bio_err,
@@ -1484,7 +1483,7 @@
}
connect_type = use_inet;
freeandcopy(&connectstr, *opt_rest());
- } else if (argc != 0) {
+ } else if (!opt_check_rest_arg(NULL)) {
goto opthelp;
}
if (!app_RAND_load())
diff --git a/apps/s_server.c b/apps/s_server.c
index d60a1f3..6b0e013 100644
--- a/apps/s_server.c
+++ b/apps/s_server.c
@@ -1648,8 +1648,7 @@
}
/* No extra arguments. */
- argc = opt_num_rest();
- if (argc != 0)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
if (!app_RAND_load())
diff --git a/apps/s_time.c b/apps/s_time.c
index 1a58e19..1c6ed78 100644
--- a/apps/s_time.c
+++ b/apps/s_time.c
@@ -234,8 +234,7 @@
}
/* No extra arguments. */
- argc = opt_num_rest();
- if (argc != 0)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
if (cipher == NULL)
diff --git a/apps/sess_id.c b/apps/sess_id.c
index 714c0f7..54b3d05 100644
--- a/apps/sess_id.c
+++ b/apps/sess_id.c
@@ -98,8 +98,7 @@
}
/* No extra arguments. */
- argc = opt_num_rest();
- if (argc != 0)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
x = load_sess_id(infile, informat);
diff --git a/apps/smime.c b/apps/smime.c
index a2ff0b5..6cf6ab3 100644
--- a/apps/smime.c
+++ b/apps/smime.c
@@ -366,10 +366,8 @@
if (!opt_md(digestname, &sign_md))
goto opthelp;
}
- if (ciphername != NULL) {
- if (!opt_cipher_any(ciphername, &cipher))
+ if (!opt_cipher_any(ciphername, &cipher))
goto opthelp;
- }
if (!(operation & SMIME_SIGNERS) && (skkeys != NULL || sksigners != NULL)) {
BIO_puts(bio_err, "Multiple signers or keys not allowed\n");
goto opthelp;
diff --git a/apps/spkac.c b/apps/spkac.c
index d92be7d..b389d9a 100644
--- a/apps/spkac.c
+++ b/apps/spkac.c
@@ -133,8 +133,7 @@
}
/* No extra arguments. */
- argc = opt_num_rest();
- if (argc != 0)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
if (!app_passwd(passinarg, NULL, &passin, NULL)) {
diff --git a/apps/storeutl.c b/apps/storeutl.c
index 1368caa..8d1ce3c 100644
--- a/apps/storeutl.c
+++ b/apps/storeutl.c
@@ -258,15 +258,12 @@
}
/* One argument, the URI */
- argc = opt_num_rest();
- argv = opt_rest();
- if (argc != 1)
+ if (!opt_check_rest_arg("URI"))
goto opthelp;
+ argv = opt_rest();
- if (digestname != NULL) {
- if (!opt_md(digestname, &digest))
- goto opthelp;
- }
+ if (!opt_md(digestname, &digest))
+ goto opthelp;
if (criterion != 0) {
switch (criterion) {
diff --git a/apps/ts.c b/apps/ts.c
index e65d223..8e58ef0 100644
--- a/apps/ts.c
+++ b/apps/ts.c
@@ -204,8 +204,10 @@
case OPT_QUERY:
case OPT_REPLY:
case OPT_VERIFY:
- if (mode != OPT_ERR)
+ if (mode != OPT_ERR) {
+ BIO_printf(bio_err, "%s: Must give only one of -query, -reply, or -verify\n", prog);
goto opthelp;
+ }
mode = o;
break;
case OPT_DATA:
@@ -288,17 +290,18 @@
}
/* No extra arguments. */
- argc = opt_num_rest();
- if (argc != 0 || mode == OPT_ERR)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
+ if (mode == OPT_ERR) {
+ BIO_printf(bio_err, "%s: Must give one of -query, -reply, or -verify\n", prog);
+ goto opthelp;
+ }
if (!app_RAND_load())
goto end;
- if (digestname != NULL) {
- if (!opt_md(digestname, &md))
- goto opthelp;
- }
+ if (!opt_md(digestname, &md))
+ goto opthelp;
if (mode == OPT_REPLY && passin &&
!app_passwd(passin, NULL, &password, NULL)) {
BIO_printf(bio_err, "Error getting password.\n");
diff --git a/apps/version.c b/apps/version.c
index cab17a4..7185e9e 100644
--- a/apps/version.c
+++ b/apps/version.c
@@ -99,8 +99,7 @@
}
/* No extra arguments. */
- argc = opt_num_rest();
- if (argc != 0)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
if (!dirty)
diff --git a/apps/x509.c b/apps/x509.c
index 28fa769..188bc17 100644
--- a/apps/x509.c
+++ b/apps/x509.c
@@ -594,13 +594,15 @@
}
/* No extra arguments. */
- argc = opt_num_rest();
- if (argc != 0)
+ if (!opt_check_rest_arg(NULL))
goto opthelp;
if (!app_RAND_load())
goto end;
+ if (!opt_check_md(digest))
+ goto opthelp;
+
if (preserve_dates && days != UNSET_DAYS) {
BIO_printf(bio_err, "Cannot use -preserve_dates with -days option\n");
goto err;
