)]}'
{
  "commit": "ee94ec2ef88e0ec25dedf2829d8e48dff0aa1c50",
  "tree": "9cd04bdad174f00d3a4c3456ea316ae094903950",
  "parents": [
    "511190b691183a1fb160e7e05e2974dc73cab0c6"
  ],
  "author": {
    "name": "Matt Caswell",
    "email": "matt@openssl.org",
    "time": "Fri May 18 11:31:31 2018 +0100"
  },
  "committer": {
    "name": "Matt Caswell",
    "email": "matt@openssl.org",
    "time": "Mon May 21 10:36:03 2018 +0100"
  },
  "message": "Don\u0027t cache stateless tickets in TLSv1.3\n\nIn TLSv1.2 and below we always cache new sessions by default on the server\nside in the internal cache (even when we\u0027re using session tickets). This is\nin order to support resumption from a session id.\n\nIn TLSv1.3 there is no session id. It is only possible to resume using the\nticket. Therefore, in the default case,  there is no point in caching the\nsession in the internal store.\n\nThere is still a reason to call the external cache new session callback\nbecause applications may be using the callbacks just to know about when\nsessions are created (and not necessarily implementing a full cache). If\nthe application also implements the remove session callback then we are\nforced to also store it in the internal cache so that we can create\ntimeout events. Otherwise the external cache could just fill up\nindefinitely.\n\nThis mostly addresses the issue described in #5628. That issue also proposes\nhaving an option to not create full stateless tickets when using the\ninternal cache. That aspect hasn\u0027t been addressed yet.\n\nReviewed-by: Rich Salz \u003crsalz@openssl.org\u003e\nReviewed-by: Ben Kaduk \u003ckaduk@mit.edu\u003e\n(Merged from https://github.com/openssl/openssl/pull/6293)\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "c38fc58a5d232625d42ae735011da46a0a3624da",
      "old_mode": 33188,
      "old_path": "ssl/ssl_lib.c",
      "new_id": "1dd355d0dadd4357480b490deb2b38496c5c0fb3",
      "new_mode": 33188,
      "new_path": "ssl/ssl_lib.c"
    },
    {
      "type": "modify",
      "old_id": "fe355f2f4c9e3f4b2fa1b16d85c248e73fc0badc",
      "old_mode": 33188,
      "old_path": "test/sslapitest.c",
      "new_id": "fe1c1e6ff3a92658acde5a1283a3928ac60c05dd",
      "new_mode": 33188,
      "new_path": "test/sslapitest.c"
    }
  ]
}