commit 1ba4ba601cc4489b167b06b16e767ba39a43fdbd
author Treehugger Robot <treehugger-gerrit@google.com> Fri Nov 09 18:41:37 2018 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Fri Nov 09 18:41:37 2018 +0000
tree 7a198686111db1c8aa0e849e15397a7fb7c5be3e
parent 7b37bbfad45feb7cd5242590da974935bde1430d
parent 10545732c0123dccb738c9c1329388746df63542

Merge "profiling/memory: tiny fixups of a couple of copy/move aspects."

src/profiling/memory/heapprofd_producer.cc

diff --git a/src/profiling/memory/heapprofd_producer.cc b/src/profiling/memory/heapprofd_producer.cc
index 912c8c1..1252b99 100644
--- a/src/profiling/memory/heapprofd_producer.cc
+++ b/src/profiling/memory/heapprofd_producer.cc
@@ -44,7 +44,7 @@
   return client_config;
 }
 
-void FindPidsForBinaries(std::vector<std::string> binaries,
+void FindPidsForBinaries(const std::vector<std::string>& binaries,
                          std::vector<pid_t>* pids) {
   base::ScopedDir proc_dir(opendir("/proc"));
   if (!proc_dir) {

src/profiling/memory/string_interner.cc

diff --git a/src/profiling/memory/string_interner.cc b/src/profiling/memory/string_interner.cc
index 088820d..f913fcf 100644
--- a/src/profiling/memory/string_interner.cc
+++ b/src/profiling/memory/string_interner.cc
@@ -20,7 +20,7 @@
 namespace profiling {
 
 StringInterner::Entry::Entry(std::string s, StringInterner* in)
-    : string(s), interner(in) {}
+    : string(std::move(s)), interner(in) {}
 
 bool StringInterner::Entry::operator<(const Entry& other) const {
   return string < other.string;
@@ -54,7 +54,7 @@
     entry_->ref_count++;
 }
 
-StringInterner::InternedString::InternedString(InternedString&& other)
+StringInterner::InternedString::InternedString(InternedString&& other) noexcept
     : entry_(other.entry_) {
   other.entry_ = nullptr;
 }

src/profiling/memory/string_interner.h

diff --git a/src/profiling/memory/string_interner.h b/src/profiling/memory/string_interner.h
index 660d0fc..29f0c22 100644
--- a/src/profiling/memory/string_interner.h
+++ b/src/profiling/memory/string_interner.h
@@ -41,7 +41,7 @@
     friend class StringInterner;
     InternedString(StringInterner::Entry* str);
     InternedString(const InternedString& other);
-    InternedString(InternedString&& other);
+    InternedString(InternedString&& other) noexcept;
     InternedString& operator=(InternedString other);
 
     const std::string& str() const;