commit 3067f8a3654d502a254039091e54831872a5fa26
author Steve Golton <stevegolton@google.com> Thu Dec 14 17:09:26 2023 +0000
committer Steve Golton <stevegolton@google.com> Thu Dec 14 17:09:26 2023 +0000
tree b02c5f319877b50a84b9eea8332c5c2c23c7e5ef
parent 8f45d30c740ad5e757cf09b916f6a1a402458054

Avoid using nullable numbers [cpu|utid|upid] in boolean expressions.

Fixes bug where CPU 0 was being omitted from aggregations.

Bug: https://github.com/google/perfetto/issues/670
Change-Id: I6dfbb6e8045bbead88fa4cc239778d89ca85ad14

ui/src/controller/flamegraph_controller.ts

diff --git a/ui/src/controller/flamegraph_controller.ts b/ui/src/controller/flamegraph_controller.ts
index d0a2d82..5ebc2e7 100644
--- a/ui/src/controller/flamegraph_controller.ts
+++ b/ui/src/controller/flamegraph_controller.ts
@@ -13,6 +13,7 @@
 // limitations under the License.
 
 import {Duration, time} from '../base/time';
+import {exists} from '../base/utils';
 import {Actions} from '../common/actions';
 import {
   defaultViewingOption,
@@ -135,7 +136,7 @@
         if (track?.uri) {
           const trackInfo = pluginManager.resolveTrackInfo(track.uri);
           if (trackInfo?.kind === PERF_SAMPLES_PROFILE_TRACK_KIND) {
-            trackInfo.upid && upids.push(trackInfo.upid);
+            exists(trackInfo.upid) && upids.push(trackInfo.upid);
           }
         }
       }