tp: improve build rules for amalgamating SQL files
Until now, we've been relying on GN variables + a home-brewn GN action
for generating the amalgamted SQL files for metrics. However, this is
barely holding together today and with the advent of
the standard library this is only going to get worse.
Fix the problem by introducing new `perfetto_sql_source_set` and
`perfetto_sql_amalgamated_header` GN templates which model the
"source_set" and "amalgamation" operations respectively. To prove it
works, we migrate the initial version of the standard library to this
new APIs.
There is some spillover into gen* scripts but ended up being reasonably
straightforward. Metrics will be migrated in a followup CL.
Bug: 255535171
Change-Id: I864a1a3df2fc8d9bb0b26dc2a943476e9c68722a
diff --git a/BUILD b/BUILD
index 241398f..d1c0f36 100644
--- a/BUILD
+++ b/BUILD
@@ -1379,7 +1379,7 @@
outs = [
"src/trace_processor/metrics/sql/amalgamated_sql_metrics.h",
],
- cmd = "$(location gen_amalgamated_sql_py) --type=METRICS --cpp_out=$@ $(SRCS)",
+ cmd = "$(location gen_amalgamated_sql_py) --namespace=sql_metrics --root-dir=src/trace_processor/metrics/sql --cpp-out=$@ $(SRCS)",
exec_tools = [
":gen_amalgamated_sql_py",
],
@@ -1492,15 +1492,32 @@
],
)
+# GN target: //src/trace_processor/stdlib/android:android
+perfetto_filegroup(
+ name = "src_trace_processor_stdlib_android_android",
+ srcs = [
+ "src/trace_processor/stdlib/android/binder.sql",
+ ],
+)
+
+# GN target: //src/trace_processor/stdlib/experimental:experimental
+perfetto_filegroup(
+ name = "src_trace_processor_stdlib_experimental_experimental",
+ srcs = [
+ "src/trace_processor/stdlib/experimental/dummy.sql",
+ ],
+)
+
perfetto_genrule(
name = "src_trace_processor_stdlib_gen_amalgamated_stdlib",
srcs = [
- "src/trace_processor/stdlib/android/binder.sql",
+ ":src_trace_processor_stdlib_android_android",
+ ":src_trace_processor_stdlib_experimental_experimental",
],
outs = [
"src/trace_processor/stdlib/amalgamated_stdlib.h",
],
- cmd = "$(location gen_amalgamated_sql_py) --type=LIB --cpp_out=$@ $(SRCS)",
+ cmd = "$(location gen_amalgamated_sql_py) --namespace=stdlib --root-dir=src/trace_processor/stdlib --cpp-out=$@ $(SRCS)",
exec_tools = [
":gen_amalgamated_sql_py",
],
