commit 380e0041413d9025205319d8905de9fa3120efe6
author Florian Mayer <fmayer@google.com> Thu Mar 08 10:23:34 2018 +0000
committer Florian Mayer <fmayer@google.com> Thu Mar 08 10:23:34 2018 +0000
tree 10bb764b85839d8b46b341f5c2ccaac954d74972
parent 22e4b396fcfd44ef7f70c5f2ecb8f665eee97742

Change const ref to pass-by-value and move.

Change-Id: I62bcceb53d22c9c3b17dff532d93cfddb8c15e40

include/perfetto/ftrace_reader/ftrace_controller.h

diff --git a/include/perfetto/ftrace_reader/ftrace_controller.h b/include/perfetto/ftrace_reader/ftrace_controller.h
index c755a19..f5df1b2 100644
--- a/include/perfetto/ftrace_reader/ftrace_controller.h
+++ b/include/perfetto/ftrace_reader/ftrace_controller.h
@@ -129,8 +129,7 @@
   static std::unique_ptr<FtraceController> Create(base::TaskRunner*);
   virtual ~FtraceController();
 
-  std::unique_ptr<FtraceSink> CreateSink(const FtraceConfig&,
-                                         FtraceSink::Delegate*);
+  std::unique_ptr<FtraceSink> CreateSink(FtraceConfig, FtraceSink::Delegate*);
 
   void DisableAllEvents();
   void WriteTraceMarker(const std::string& s);

src/ftrace_reader/ftrace_controller.cc

diff --git a/src/ftrace_reader/ftrace_controller.cc b/src/ftrace_reader/ftrace_controller.cc
index 7d5bb2f..ccf2022 100644
--- a/src/ftrace_reader/ftrace_controller.cc
+++ b/src/ftrace_reader/ftrace_controller.cc
@@ -271,7 +271,7 @@
 }
 
 std::unique_ptr<FtraceSink> FtraceController::CreateSink(
-    const FtraceConfig& config,
+    FtraceConfig config,
     FtraceSink::Delegate* delegate) {
   PERFETTO_DCHECK_THREAD(thread_checker_);
   if (sinks_.size() >= kMaxSinks)
@@ -287,8 +287,9 @@
   auto filter = std::unique_ptr<EventFilter>(new EventFilter(
       *table_, FtraceEventsAsSet(*ftrace_config_muxer_->GetConfig(id))));
 
-  auto sink = std::unique_ptr<FtraceSink>(new FtraceSink(
-      std::move(controller_weak), id, config, std::move(filter), delegate));
+  auto sink = std::unique_ptr<FtraceSink>(
+      new FtraceSink(std::move(controller_weak), id, std::move(config),
+                     std::move(filter), delegate));
   Register(sink.get());
   return sink;
 }