commit 39e40d4d7a21c3ab7de3e6f5b3dcadc6dd50d204
author Florian Mayer <fmayer@google.com> Thu Jul 16 14:52:07 2020 +0200
committer Lalit Maganti <lalitm@google.com> Fri Jul 17 11:59:11 2020 +0000
tree 574739ddccff44bb6c7ba9d0bbd1f59ecf6e7fc3
parent aad72e08c473654dfa2b0c1da5f74846209331cd

Build without -Wno-implicit-int-float-conversion.

The warning does occasionally flag interesting issues, e.g. when a
literal cannot be accurately represented as a float.

Change-Id: Ie3e285b26838be20e012051d345f79b7afee6e0d

src/trace_processor/trace_processor_shell.cc

diff --git a/src/trace_processor/trace_processor_shell.cc b/src/trace_processor/trace_processor_shell.cc
index e8e2c18..c9c5046 100644
--- a/src/trace_processor/trace_processor_shell.cc
+++ b/src/trace_processor/trace_processor_shell.cc
@@ -494,7 +494,8 @@
   if (!status.ok()) {
     PERFETTO_ELOG("SQLite error: %s", status.c_message());
   }
-  printf("\nQuery executed in %.3f ms\n\n", (t_end - t_start).count() / 1E6);
+  printf("\nQuery executed in %.3f ms\n\n",
+         static_cast<double>((t_end - t_start).count()) / 1E6);
 }
 
 void PrintShellUsage() {
@@ -975,7 +976,7 @@
 util::Status LoadTrace(const std::string& trace_file_path, double* size_mb) {
   util::Status read_status =
       ReadTrace(g_tp, trace_file_path.c_str(), [&size_mb](size_t parsed_size) {
-        *size_mb = parsed_size / 1E6;
+        *size_mb = static_cast<double>(parsed_size) / 1E6;
         fprintf(stderr, "\rLoading trace: %.2f MB\r", *size_mb);
       });
   if (!read_status.ok()) {
@@ -1109,7 +1110,7 @@
     RETURN_IF_ERROR(LoadTrace(options.trace_file_path, &size_mb));
     t_load = base::GetWallTimeNs() - t_load_start;
 
-    double t_load_s = t_load.count() / 1E9;
+    double t_load_s = static_cast<double>(t_load.count()) / 1E9;
     PERFETTO_ILOG("Trace loaded: %.2f MB (%.1f MB/s)", size_mb,
                   size_mb / t_load_s);