ui: change "dead" task color to gray and render dead tasks from old kernels (<4.14)
thread_state.state='X' is how we currently represent dead tasks, and
that is rendered with a relatively loud indigo colour by the UI.
The thread query currently drops 'x' (lowercase!), but that
only covers very old traces on kernels <4.14.
So there are two options:
(a) hide 'X' for new traces as well.
(b) render all dead states, but choose a less distracting colour.
I went with option (b) since I think that knowing that a thread is done
can be quite useful when looking at a process with many threads.
Don't have a good way of hosting images, so here's an internal
screenshot: https://screenshot.googleplex.com/BThdsYv4ZoBYFcT.png
Change-Id: Iba06226812cd939b08e89105e27d296ea016390b
diff --git a/test/data/ui-screenshots/ui-android_trace_30s_expand_camera.png.sha256 b/test/data/ui-screenshots/ui-android_trace_30s_expand_camera.png.sha256
index a359061..6c9da12 100644
--- a/test/data/ui-screenshots/ui-android_trace_30s_expand_camera.png.sha256
+++ b/test/data/ui-screenshots/ui-android_trace_30s_expand_camera.png.sha256
@@ -1 +1 @@
-4b4bd13cbae5710efda25c6e2495c7ec5614d348701b9fec1fd554d5b1c61064
\ No newline at end of file
+3b1182b4e24fa80004c5bcec56c2cc9b4814ed9da7266fe54fafde4191ab3b4f
\ No newline at end of file
diff --git a/ui/src/core/colorizer.ts b/ui/src/core/colorizer.ts
index 3850e1e..3f0d1b3 100644
--- a/ui/src/core/colorizer.ts
+++ b/ui/src/core/colorizer.ts
@@ -182,6 +182,8 @@
return DESAT_RED;
}
return ORANGE;
+ } else if (state.includes('Dead')) {
+ return GRAY;
} else if (state.includes('Sleeping') || state.includes('Idle')) {
return TRANSPARENT_WHITE;
}
diff --git a/ui/src/tracks/thread_state/thread_state_v2.ts b/ui/src/tracks/thread_state/thread_state_v2.ts
index 4ab000f..1d0b31f 100644
--- a/ui/src/tracks/thread_state/thread_state_v2.ts
+++ b/ui/src/tracks/thread_state/thread_state_v2.ts
@@ -55,12 +55,7 @@
}
getSqlSource(): string {
- // Do not display states:
- // 'x' (dead), 'S' (sleeping), 'I' (idle kernel thread).
- // Note: Thread state tracks V1 basically ignores incomplete slices, faking
- // their duration as 1 instead. Let's just do this here as well for now to
- // achieve feature parity with tracks V1 and tackle the issue of overlapping
- // incomplete slices later.
+ // Do not display states: 'S' (sleeping), 'I' (idle kernel thread).
return `
select
id,
@@ -73,7 +68,7 @@
from thread_state
where
utid = ${this.utid} and
- state not in ('x', 'S', 'I')
+ state not in ('S', 'I')
`;
}
