commit 3d3de5af2d068c6a331f4984a0d0d6a67fe91d2c
author Daniele Di Proietto <ddiproietto@google.com> Mon Oct 07 13:59:50 2024 +0000
committer Daniele Di Proietto <ddiproietto@google.com> Mon Oct 07 14:12:50 2024 +0000
tree 2b18bc2f994f7c354779e0178e0adc0c70532517
parent deee9b14a4494be079757cd9e223506400bae16c

tracing_integration_test: Remove WaitForTraceWritersChanged

It accesses internal implementation details. Let's use RunUntilIdle()
instead.

Change-Id: I84e09d299c1293489e2674e83bf90a771f19c203

src/tracing/test/tracing_integration_test.cc

diff --git a/src/tracing/test/tracing_integration_test.cc b/src/tracing/test/tracing_integration_test.cc
index 45def13..b9c2bac 100644
--- a/src/tracing/test/tracing_integration_test.cc
+++ b/src/tracing/test/tracing_integration_test.cc
@@ -200,35 +200,6 @@
     return TracingService::ProducerSMBScrapingMode::kDefault;
   }
 
-  void WaitForTraceWritersChanged(ProducerID producer_id) {
-    static int i = 0;
-    auto checkpoint_name = "writers_changed_" + std::to_string(producer_id) +
-                           "_" + std::to_string(i++);
-    auto writers_changed = task_runner_->CreateCheckpoint(checkpoint_name);
-    auto writers = GetWriters(producer_id);
-    std::function<void()> task;
-    task = [&task, writers, writers_changed, producer_id, this]() {
-      if (writers != GetWriters(producer_id)) {
-        writers_changed();
-        return;
-      }
-      task_runner_->PostDelayedTask(task, 1);
-    };
-    task_runner_->PostDelayedTask(task, 1);
-    task_runner_->RunUntilCheckpoint(checkpoint_name);
-  }
-
-  const std::map<WriterID, BufferID>& GetWriters(ProducerID producer_id) {
-    return reinterpret_cast<TracingServiceImpl*>(svc_->service())
-        ->GetProducer(producer_id)
-        ->writers_;
-  }
-
-  ProducerID* last_producer_id() {
-    return &reinterpret_cast<TracingServiceImpl*>(svc_->service())
-                ->last_producer_id_;
-  }
-
   std::unique_ptr<base::TestTaskRunner> task_runner_;
   std::unique_ptr<ServiceIPCHost> svc_;
   std::unique_ptr<TracingService::ProducerEndpoint> producer_endpoint_;
@@ -515,7 +486,7 @@
   ASSERT_TRUE(writer);
 
   // Wait for the writer to be registered.
-  WaitForTraceWritersChanged(*last_producer_id());
+  task_runner_->RunUntilIdle();
 
   // Write a few trace packets.
   writer->NewTracePacket()->set_for_testing()->set_str("payload1");