Trace Redaction - Move Redactor+Context out of fixture
The integration test fixture's core responsibility is to manage source
trace and redacted trace files. Some common values we add to it to
avoid declaring them in every test (redactor and context).
This coupling was okay when each test populated the redactor. However,
we'll be adding tests that use the production config and having this
silent default value has already caused issued when not reset.
To avoid this easy mistakes, this removes the redactor and context
from the fixture and requires each test to provide their own.
Change-Id: Ica0e0752bf2f092a914f0d3bc262242615ec0bd4
diff --git a/src/trace_redaction/trace_redaction_integration_fixture.cc b/src/trace_redaction/trace_redaction_integration_fixture.cc
index 85555f3..9fc38d2 100644
--- a/src/trace_redaction/trace_redaction_integration_fixture.cc
+++ b/src/trace_redaction/trace_redaction_integration_fixture.cc
@@ -27,8 +27,10 @@
dest_trace_ = tmp_dir_.AbsolutePath("dst.pftrace");
}
-base::Status TraceRedactionIntegrationFixure::Redact() {
- auto status = trace_redactor_.Redact(src_trace_, dest_trace_, &context_);
+base::Status TraceRedactionIntegrationFixure::Redact(
+ const TraceRedactor& redactor,
+ Context* context) {
+ auto status = redactor.Redact(src_trace_, dest_trace_, context);
if (status.ok()) {
tmp_dir_.TrackFile("dst.pftrace");
