| commit | d4eec8e21e89d2054558e167f5a958a1d2ab4336 | [log] [tgz] |
|---|---|---|
| author | Sami Kyostila <skyostil@google.com> | Tue May 05 15:56:42 2020 +0100 |
| committer | Sami Kyostila <skyostil@google.com> | Tue May 05 15:56:42 2020 +0100 |
| tree | 48c76e442da2a1395ac1f7a7aab0dc0065024aa6 | |
| parent | ff70e0d273ed10995866c803f23e11250eb3dc52 [diff] |
TrackEvent: Make process/thread naming less of a footgun
When calling TrackEvent::Set{Process,Thread}Descriptor, it's tempting to
set the |name| field of the returned TrackDescriptor to record the name
of the thread or process, but this only ends up setting the name of the
track object which is associated with the thread or process, and is not
directly displayed by the UI.
Instead, one should name the thread or process by filling in the
{Process,Thread}Descriptor message inside the TrackDescriptor. This
patch makes the API more conducive to doing that by accepting
protos::gen track descriptors -- which are more easily mutated by the
user -- while maintaining backwards compatibility with the original
behavior.
Bug: 155076522
Change-Id: I7c8c9032c8e7d59a28c90c81a2b11424a7bce5e2Perfetto is an open-source project for performance instrumentation and tracing of Linux/Android/Chrome platforms and user-space apps.
See www.perfetto.dev for docs.
See /docs/contributing.md for instructions.
The source-of-truth repo is Android's Gerrit. The GitHub repo is a read-only mirror.
You can reach us on our Discord channel. If you prefer using IRC we have an experimental Discord <> IRC bridge synced with #perfetto-dev on Freenode.