TODO(taylori) -> TODO(hjd)
Change-Id: Ibe6b7e2e8387fa98dad3e37d957896e4e73eef34
diff --git a/src/trace_processor/importers/ftrace/binder_tracker.cc b/src/trace_processor/importers/ftrace/binder_tracker.cc
index f8e040d..d866c0a 100644
--- a/src/trace_processor/importers/ftrace/binder_tracker.cc
+++ b/src/trace_processor/importers/ftrace/binder_tracker.cc
@@ -106,7 +106,7 @@
base::StringView(flag_str))));
inserter->AddArg(code_, Variadic::String(code));
inserter->AddArg(calling_tid_, Variadic::UnsignedInteger(tid));
- // TODO(taylori): The legacy UI included the calling pid in the args,
+ // TODO(hjd): The legacy UI included the calling pid in the args,
// is this necessary? It's complicated in our case because process
// association might not happen until after the binder transaction slices
// have been parsed. We would need to backfill the arg.
diff --git a/src/trace_processor/importers/ftrace/ftrace_parser.cc b/src/trace_processor/importers/ftrace/ftrace_parser.cc
index ebcd102..654b332 100644
--- a/src/trace_processor/importers/ftrace/ftrace_parser.cc
+++ b/src/trace_processor/importers/ftrace/ftrace_parser.cc
@@ -1005,7 +1005,7 @@
}
void FtraceParser::ParseLowmemoryKill(int64_t timestamp, ConstBytes blob) {
- // TODO(taylori): Store the pagecache_size, pagecache_limit and free fields
+ // TODO(hjd): Store the pagecache_size, pagecache_limit and free fields
// in an args table
protos::pbzero::LowmemoryKillFtraceEvent::Decoder lmk(blob.data, blob.size);
diff --git a/src/trace_processor/importers/proto/proto_trace_parser_unittest.cc b/src/trace_processor/importers/proto/proto_trace_parser_unittest.cc
index 9cab42b..0a0de1d 100644
--- a/src/trace_processor/importers/proto/proto_trace_parser_unittest.cc
+++ b/src/trace_processor/importers/proto/proto_trace_parser_unittest.cc
@@ -383,7 +383,7 @@
ASSERT_EQ(args.int_value()[4], 20);
ASSERT_STREQ(args.string_value().GetString(5).c_str(), buf_value);
- // TODO(taylori): Add test ftrace event with all field types
+ // TODO(hjd): Add test ftrace event with all field types
// and test here.
}
diff --git a/src/trace_processor/sqlite/sqlite_raw_table.cc b/src/trace_processor/sqlite/sqlite_raw_table.cc
index 0b5b9e9..875025d 100644
--- a/src/trace_processor/sqlite/sqlite_raw_table.cc
+++ b/src/trace_processor/sqlite/sqlite_raw_table.cc
@@ -602,7 +602,7 @@
} else if (name.empty()) {
name = "<unknown>";
} else if (name == "CrRendererMain") {
- // TODO(taylori): Remove this when crbug.com/978093 is fixed or
+ // TODO(hjd): Remove this when crbug.com/978093 is fixed or
// when a better solution is found.
name = "CrRendererMainThread";
}
diff --git a/src/trace_processor/types/gfp_flags.cc b/src/trace_processor/types/gfp_flags.cc
index 30a5932..acb52fb 100644
--- a/src/trace_processor/types/gfp_flags.cc
+++ b/src/trace_processor/types/gfp_flags.cc
@@ -208,7 +208,7 @@
} else if (version >= VersionNumber{4, 4} && version < VersionNumber{4, 14}) {
return &v4_4;
} else { // version >= 4.14
- // TODO(taylori): Add newer kernel versions once we have access to them.
+ // TODO(hjd): Add newer kernel versions once we have access to them.
return &v4_14;
}
}
diff --git a/src/traced/probes/ftrace/cpu_reader.cc b/src/traced/probes/ftrace/cpu_reader.cc
index eaba2b2..facd4ce 100644
--- a/src/traced/probes/ftrace/cpu_reader.cc
+++ b/src/traced/probes/ftrace/cpu_reader.cc
@@ -634,7 +634,7 @@
for (const Field& field : info.fields) {
auto generic_field = nested->BeginNestedMessage<protozero::Message>(
GenericFtraceEvent::kFieldFieldNumber);
- // TODO(taylori): Avoid outputting field names every time.
+ // TODO(hjd): Avoid outputting field names every time.
generic_field->AppendString(GenericFtraceEvent::Field::kNameFieldNumber,
field.ftrace_name);
success &= ParseField(field, start, end, table, generic_field, metadata);
diff --git a/ui/src/assets/common.scss b/ui/src/assets/common.scss
index 1675e71..0324899 100644
--- a/ui/src/assets/common.scss
+++ b/ui/src/assets/common.scss
@@ -367,7 +367,7 @@
overflow-x: hidden;
overflow-y: auto;
flex: 1 1 auto;
- // TODO(taylori): This causes the sticky header to flicker when scrolling.
+ // TODO(hjd): This causes the sticky header to flicker when scrolling.
// Is will-change necessary in the details panel?
// will-change: transform;
display: grid;
diff --git a/ui/src/controller/aggregation/aggregation_controller.ts b/ui/src/controller/aggregation/aggregation_controller.ts
index 7b2d941..0892e37 100644
--- a/ui/src/controller/aggregation/aggregation_controller.ts
+++ b/ui/src/controller/aggregation/aggregation_controller.ts
@@ -166,7 +166,7 @@
}
columnFromColumnDef(def: ColumnDef, numRows: number): Column {
- // TODO(taylori): The Column type should be based on the
+ // TODO(hjd): The Column type should be based on the
// ColumnDef type or vice versa to avoid this cast.
return {
title: def.title,
diff --git a/ui/src/controller/aggregation/counter_aggregation_controller.ts b/ui/src/controller/aggregation/counter_aggregation_controller.ts
index ff2dbc3..24d4a94 100644
--- a/ui/src/controller/aggregation/counter_aggregation_controller.ts
+++ b/ui/src/controller/aggregation/counter_aggregation_controller.ts
@@ -31,7 +31,7 @@
// Track will be undefined for track groups.
if (track !== undefined && track.kind === COUNTER_TRACK_KIND) {
const config = track.config as Config;
- // TODO(taylori): Also aggregate annotation (with namespace) counters.
+ // TODO(hjd): Also aggregate annotation (with namespace) counters.
if (config.namespace === undefined) {
ids.push(config.trackId);
}
diff --git a/ui/src/controller/heap_profile_controller.ts b/ui/src/controller/heap_profile_controller.ts
index c152590..c424b8f 100644
--- a/ui/src/controller/heap_profile_controller.ts
+++ b/ui/src/controller/heap_profile_controller.ts
@@ -210,7 +210,7 @@
if (this.flamegraphDatasets.has(key)) {
currentData = this.flamegraphDatasets.get(key)!;
} else {
- // TODO(taylori): Show loading state.
+ // TODO(hjd): Show loading state.
// Collecting data for drawing flamegraph for selected heap profile.
// Data needs to be in following format:
diff --git a/ui/src/controller/record_controller.ts b/ui/src/controller/record_controller.ts
index f5b66eb..a124ecf 100644
--- a/ui/src/controller/record_controller.ts
+++ b/ui/src/controller/record_controller.ts
@@ -246,7 +246,7 @@
let heapprofd: HeapprofdConfig|undefined = undefined;
if (uiCfg.heapProfiling) {
- // TODO(taylori): Check or inform user if buffer size are too small.
+ // TODO(hjd): Check or inform user if buffer size are too small.
const cfg = new HeapprofdConfig();
cfg.samplingIntervalBytes = uiCfg.hpSamplingIntervalBytes;
if (uiCfg.hpSharedMemoryBuffer >= 8192 &&
diff --git a/ui/src/controller/selection_controller.ts b/ui/src/controller/selection_controller.ts
index 69891ae..5adb795 100644
--- a/ui/src/controller/selection_controller.ts
+++ b/ui/src/controller/selection_controller.ts
@@ -176,7 +176,7 @@
where slice_id = ${sliceId}`;
const destResult = await this.args.engine.query(trackIdQuery);
const trackIdTp = destResult.columns[0].longValues![0];
- // TODO(taylori): If we had a consistent mapping from TP track_id
+ // TODO(hjd): If we had a consistent mapping from TP track_id
// UI track id for slice tracks this would be unnecessary.
let trackId = '';
for (const track of Object.values(globals.state.tracks)) {
diff --git a/ui/src/controller/track_decider.ts b/ui/src/controller/track_decider.ts
index cfb8722..e7e785b 100644
--- a/ui/src/controller/track_decider.ts
+++ b/ui/src/controller/track_decider.ts
@@ -154,7 +154,7 @@
for (const cpu of cpus) {
// Only add a cpu freq track if we have
// cpu freq data.
- // TODO(taylori): Find a way to display cpu idle
+ // TODO(hjd): Find a way to display cpu idle
// events even if there are no cpu freq events.
const cpuFreqIdle = await this.engine.query(`
select
diff --git a/ui/src/frontend/notes_panel.ts b/ui/src/frontend/notes_panel.ts
index 7deea7d..017deea 100644
--- a/ui/src/frontend/notes_panel.ts
+++ b/ui/src/frontend/notes_panel.ts
@@ -139,7 +139,7 @@
}
// A real note is hovered so we don't need to see the preview line.
- // TODO(taylori): Change cursor to pointer here.
+ // TODO(hjd): Change cursor to pointer here.
if (aNoteIsHovered) globals.frontendLocalState.setHoveredNoteTimestamp(-1);
// View preview note flag when hovering on notes panel.
diff --git a/ui/src/frontend/pan_and_zoom_handler.ts b/ui/src/frontend/pan_and_zoom_handler.ts
index b5a814d..166a3ce 100644
--- a/ui/src/frontend/pan_and_zoom_handler.ts
+++ b/ui/src/frontend/pan_and_zoom_handler.ts
@@ -279,7 +279,7 @@
handleKey(e, false);
}
- // TODO(taylori): Move this shift handling into the viewer page.
+ // TODO(hjd): Move this shift handling into the viewer page.
private updateShift(down: boolean) {
if (down === this.shiftDown) return;
this.shiftDown = down;
diff --git a/ui/src/frontend/record_page.ts b/ui/src/frontend/record_page.ts
index e8a5947..f493630 100644
--- a/ui/src/frontend/record_page.ts
+++ b/ui/src/frontend/record_page.ts
@@ -408,7 +408,7 @@
setEnabled: (cfg, val) => cfg.hpAllHeaps = val,
isEnabled: (cfg) => cfg.hpAllHeaps
} as ToggleAttrs)
- // TODO(taylori): Add advanced options.
+ // TODO(hjd): Add advanced options.
);
}
diff --git a/ui/src/frontend/scroll_helper.ts b/ui/src/frontend/scroll_helper.ts
index 53874c7..be24399 100644
--- a/ui/src/frontend/scroll_helper.ts
+++ b/ui/src/frontend/scroll_helper.ts
@@ -29,7 +29,7 @@
const endNs = toNs(globals.frontendLocalState.visibleWindowTime.end);
const currentViewNs = endNs - startNs;
if (ts < startNs || ts > endNs) {
- // TODO(taylori): This is an ugly jump, we should do a smooth pan instead.
+ // TODO(hjd): This is an ugly jump, we should do a smooth pan instead.
globals.frontendLocalState.updateVisibleTime(new TimeSpan(
fromNs(ts - currentViewNs / 2), fromNs(ts + currentViewNs / 2)));
}
diff --git a/ui/src/frontend/search_handler.ts b/ui/src/frontend/search_handler.ts
index 091f54f..cfdc259 100644
--- a/ui/src/frontend/search_handler.ts
+++ b/ui/src/frontend/search_handler.ts
@@ -61,7 +61,7 @@
}
selectCurrentSearchResult();
- // TODO(taylori): If the user does a search before any other selection,
+ // TODO(hjd): If the user does a search before any other selection,
// the details panel will pop up when the search is executed. If the search
// result is behind where the details panel appears then it won't get scrolled
// to. This time delay is a workaround for this specific situation.
diff --git a/ui/src/frontend/thread_state_panel.ts b/ui/src/frontend/thread_state_panel.ts
index 048c4e1..164b3a5 100644
--- a/ui/src/frontend/thread_state_panel.ts
+++ b/ui/src/frontend/thread_state_panel.ts
@@ -75,10 +75,11 @@
return [
`${state} on CPU ${cpu}`,
- m('i.material-icons.grey',
- {
- onclick: () => {
- // TODO(taylori): Use trackId from TP.
+ m(
+ 'i.material-icons.grey',
+ {
+ onclick: () => {
+ // TODO(hjd): Use trackId from TP.
let trackId;
for (const track of Object.values(globals.state.tracks)) {
if (track.kind === 'CpuSliceTrack' &&
@@ -92,10 +93,10 @@
scrollToTrackAndTs(
trackId, toNs(ts + globals.state.traceTime.startSec));
}
+ },
+ title: 'Go to CPU slice'
},
- title: 'Go to CPU slice'
- },
- 'call_made')
+ 'call_made')
];
}
