Google Git
Sign in
flutter / third_party / perfetto / 704bc82504e53c450098fdf8b9f2545d086bf5fe
commit704bc82504e53c450098fdf8b9f2545d086bf5fe[log] [tgz]
authorRyan <rsavitski@google.com>Tue Mar 31 02:31:13 2020 +0100
committerRyan Savitski <rsavitski@google.com>Tue Mar 31 01:36:33 2020 +0000
tree6edcfe906f7a962e19363608d98947e24da134a7
parentde6d9fd4428c078ddbf5526203cf3d00d1d8602c [diff]
Ban PERFETTO_EINTR(close(...)), which is actively incorrect

This is a surprisingly tangled topic, since POSIX left the behaviour
on EINTR unspecified, and implementations diverged.

See e.g. http://crbug.com/269623 for more background.

Fun side question that follows: do we need to bother with
complicating base::ScopedFile with EINTR comparisons to avoid the CHECK
on close from firing in very unlikely/impossible(?) scenarios?

Change-Id: I77633d63e5855ed2c27c5498a79798b3d8cdfc53
5 files changed
tree: 6edcfe906f7a962e19363608d98947e24da134a7
  1. bazel/
  2. build_overrides/
  3. buildtools/
  4. debian/
  5. docs/
  6. gn/
  7. include/
  8. infra/
  9. protos/
  10. src/
  11. test/
  12. tools/
  13. ui/
  14. .clang-format
  15. .gitignore
  16. .gn
  17. .style.yapf
  18. Android.bp
  19. Android.bp.extras
  20. BUILD
  21. BUILD.extras
  22. BUILD.gn
  23. codereview.settings
  24. heapprofd.rc
  25. LICENSE
  26. MODULE_LICENSE_APACHE2
  27. OWNERS
  28. perfetto.rc
  29. PRESUBMIT.py
  30. README.chromium
  31. README.md
  32. TEST_MAPPING
  33. traced_perf.rc
  34. WORKSPACE
README.md

Perfetto - Performance instrumentation and tracing

Perfetto is an open-source project for performance instrumentation and tracing of Linux/Android/Chrome platforms and user-space apps.

See www.perfetto.dev for docs.

Contributing

See /docs/contributing.md for instructions.

The source-of-truth repo is Android's Gerrit. The GitHub repo is a read-only mirror.

Bugs

  • For bugs affecting Android or the tracing internals use the internal bug tracker (go/perfetto-bugs).
  • For bugs affecting Chrome use http://crbug.com, Component:Speed>Tracing label:Perfetto.

Community

You can reach us on our Discord channel. If you prefer using IRC we have an experimental Discord <> IRC bridge synced with #perfetto-dev on Freenode.