Update the duration thresholds that are percentage of ttff for slow start reasons.
Bug: 269225716
Change-Id: Ied9a123ec7ef635901bc0b7b78d43e19e409e489
diff --git a/src/trace_processor/metrics/sql/android/android_startup.sql b/src/trace_processor/metrics/sql/android/android_startup.sql
index 8399ddb..50da014 100644
--- a/src/trace_processor/metrics/sql/android/android_startup.sql
+++ b/src/trace_processor/metrics/sql/android/android_startup.sql
@@ -315,12 +315,14 @@
UNION ALL
SELECT 'Main Thread - Time spent in Running state'
AS slow_cause
- WHERE MAIN_THREAD_TIME_FOR_LAUNCH_AND_STATE(launches.startup_id, 'Running') > 150e6
+ WHERE
+ MAIN_THREAD_TIME_FOR_LAUNCH_AND_STATE(launches.startup_id, 'Running') > launches.dur * 0.8
UNION ALL
SELECT 'Main Thread - Time spent in Runnable state'
AS slow_cause
- WHERE MAIN_THREAD_TIME_FOR_LAUNCH_IN_RUNNABLE_STATE(launches.startup_id) > 100e6
+ WHERE
+ MAIN_THREAD_TIME_FOR_LAUNCH_IN_RUNNABLE_STATE(launches.startup_id) > launches.dur * 0.15
UNION ALL
SELECT 'Main Thread - Time spent in interruptible sleep state'
@@ -334,7 +336,9 @@
UNION ALL
SELECT 'Time spent in OpenDexFilesFromOat*'
AS slow_cause
- WHERE ANDROID_SUM_DUR_FOR_STARTUP_AND_SLICE(launches.startup_id, 'OpenDexFilesFromOat*') > 1e6
+ WHERE
+ ANDROID_SUM_DUR_FOR_STARTUP_AND_SLICE(launches.startup_id, 'OpenDexFilesFromOat*')
+ > launches.dur * 0.2
UNION ALL
SELECT 'Time spent in bindApplication'
@@ -355,7 +359,9 @@
UNION ALL
SELECT 'Time spent verifying classes'
AS slow_cause
- WHERE ANDROID_SUM_DUR_FOR_STARTUP_AND_SLICE(launches.startup_id, 'VerifyClass*') > 10e6
+ WHERE
+ ANDROID_SUM_DUR_FOR_STARTUP_AND_SLICE(launches.startup_id, 'VerifyClass*')
+ > launches.dur * 0.15
UNION ALL
SELECT 'Potential CPU contention with '
@@ -379,7 +385,7 @@
WHERE ANDROID_SUM_DUR_ON_MAIN_THREAD_FOR_STARTUP_AND_SLICE(
launches.startup_id,
'Lock contention on*'
- ) > 25e6
+ ) > launches.dur * 0.2
UNION ALL
SELECT 'Main Thread - Monitor contention'
@@ -387,7 +393,7 @@
WHERE ANDROID_SUM_DUR_ON_MAIN_THREAD_FOR_STARTUP_AND_SLICE(
launches.startup_id,
'Lock contention on a monitor*'
- ) > 40e6
+ ) > launches.dur * 0.15
UNION ALL
SELECT 'GC Activity'
diff --git a/test/trace_processor/diff_tests/startup/android_startup.out b/test/trace_processor/diff_tests/startup/android_startup.out
index f804a34..48fa752 100644
--- a/test/trace_processor/diff_tests/startup/android_startup.out
+++ b/test/trace_processor/diff_tests/startup/android_startup.out
@@ -62,6 +62,7 @@
installd_dur_ns: 0
dex2oat_dur_ns: 0
}
+ slow_start_reason: "Main Thread - Time spent in Runnable state"
startup_type: "warm"
}
}
diff --git a/test/trace_processor/diff_tests/startup/android_startup_attribution_slow.out b/test/trace_processor/diff_tests/startup/android_startup_attribution_slow.out
index 475edf8..ea33f96 100644
--- a/test/trace_processor/diff_tests/startup/android_startup_attribution_slow.out
+++ b/test/trace_processor/diff_tests/startup/android_startup_attribution_slow.out
@@ -74,8 +74,6 @@
dex2oat_dur_ns: 0
}
startup_type: "hot"
- slow_start_reason: "Time spent in OpenDexFilesFromOat*"
- slow_start_reason: "Time spent verifying classes"
slow_start_reason: "JIT Activity"
slow_start_reason: "GC Activity"
slow_start_reason: "JIT compiled methods"
diff --git a/test/trace_processor/diff_tests/startup/android_startup_breakdown.out b/test/trace_processor/diff_tests/startup/android_startup_breakdown.out
index 132aad8..5baa172 100644
--- a/test/trace_processor/diff_tests/startup/android_startup_breakdown.out
+++ b/test/trace_processor/diff_tests/startup/android_startup_breakdown.out
@@ -102,8 +102,6 @@
installd_dur_ns: 0
dex2oat_dur_ns: 0
}
- slow_start_reason: "Main Thread - Time spent in Running state"
- slow_start_reason: "Main Thread - Time spent in Runnable state"
slow_start_reason: "Time spent in bindApplication"
slow_start_reason: "Time spent in view inflation"
slow_start_reason: "Time spent in ResourcesManager#getResources"
diff --git a/test/trace_processor/diff_tests/startup/android_startup_breakdown_slow.out b/test/trace_processor/diff_tests/startup/android_startup_breakdown_slow.out
index 2974f88..c58d970 100644
--- a/test/trace_processor/diff_tests/startup/android_startup_breakdown_slow.out
+++ b/test/trace_processor/diff_tests/startup/android_startup_breakdown_slow.out
@@ -102,8 +102,6 @@
installd_dur_ns: 0
dex2oat_dur_ns: 0
}
- slow_start_reason: "Main Thread - Time spent in Running state"
- slow_start_reason: "Main Thread - Time spent in Runnable state"
slow_start_reason: "Time spent in bindApplication"
slow_start_reason: "Time spent in view inflation"
slow_start_reason: "Time spent in ResourcesManager#getResources"
diff --git a/test/trace_processor/diff_tests/startup/android_startup_lock_contention_slow.out b/test/trace_processor/diff_tests/startup/android_startup_lock_contention_slow.out
index 09a342a..cd5dc6c 100644
--- a/test/trace_processor/diff_tests/startup/android_startup_lock_contention_slow.out
+++ b/test/trace_processor/diff_tests/startup/android_startup_lock_contention_slow.out
@@ -33,12 +33,12 @@
dur_ms: 2000.0
}
time_lock_contention_thread_main {
- dur_ns: 20000000000
- dur_ms: 20000.0
+ dur_ns: 27000000000
+ dur_ms: 27000.0
}
time_monitor_contention_thread_main {
- dur_ns: 10000000000
- dur_ms: 10000.0
+ dur_ns: 17000000000
+ dur_ms: 17000.0
}
}
activity_hosting_process_count: 1
diff --git a/test/trace_processor/diff_tests/startup/android_startup_lock_contention_slow.py b/test/trace_processor/diff_tests/startup/android_startup_lock_contention_slow.py
index c447b08..482549c 100644
--- a/test/trace_processor/diff_tests/startup/android_startup_lock_contention_slow.py
+++ b/test/trace_processor/diff_tests/startup/android_startup_lock_contention_slow.py
@@ -60,7 +60,7 @@
tid=3,
pid=3,
buf='Lock contention on a monitor lock (owner tid: 2)')
-trace.add_atrace_end(ts=to_s(150), tid=3, pid=3)
+trace.add_atrace_end(ts=to_s(157), tid=3, pid=3)
# Lock contention on non-main thread should not be counted.
trace.add_atrace_begin(
diff --git a/test/trace_processor/diff_tests/startup/android_startup_slow.out b/test/trace_processor/diff_tests/startup/android_startup_slow.out
index 22f2d90..3b5d1ab 100644
--- a/test/trace_processor/diff_tests/startup/android_startup_slow.out
+++ b/test/trace_processor/diff_tests/startup/android_startup_slow.out
@@ -63,7 +63,6 @@
dex2oat_dur_ns: 0
}
startup_type: "warm"
- slow_start_reason: "Main Thread - Time spent in Running state"
slow_start_reason: "Main Thread - Time spent in Runnable state"
slow_start_reason: "Main Thread - Time spent in interruptible sleep state"
slow_start_reason: "Main Thread - Time spent in Blocking I/O"
