Google Git
Sign in
flutter / third_party / perfetto / 8c8e997095469edf67f7cc8979400b842a0c46d7
commit8c8e997095469edf67f7cc8979400b842a0c46d7[log] [tgz]
authorLalit Maganti <lalitm@google.com>Tue Apr 07 17:47:54 2020 +0100
committerLalit Maganti <lalitm@google.com>Wed Apr 08 11:08:29 2020 +0000
tree8bd0341f2386d806e75bb49403053a2e90ed9e96
parent3b13db544626b44068c8f0c35319deceb63bcaf2 [diff]
tp: fix inconsistency of base::optional<StringId> column API

Before this CL, we would return StringId::Null() from
base::Optional<StringId> columns whereas we would expect base::nullopt
to be returned.

Fix this behaviour at the cost of converting insertions of
StringId::Null() into base::nullopt - this conversion is more intuitive
than the reverse so we accept the small usability price.

Change-Id: I8f9e61cd3782f3eec3f8961581e43fd1165d7b9e
6 files changed
tree: 8bd0341f2386d806e75bb49403053a2e90ed9e96
  1. bazel/
  2. build_overrides/
  3. buildtools/
  4. debian/
  5. docs/
  6. gn/
  7. include/
  8. infra/
  9. protos/
  10. src/
  11. test/
  12. tools/
  13. ui/
  14. .clang-format
  15. .gitignore
  16. .gn
  17. .style.yapf
  18. Android.bp
  19. Android.bp.extras
  20. BUILD
  21. BUILD.extras
  22. BUILD.gn
  23. codereview.settings
  24. heapprofd.rc
  25. LICENSE
  26. MODULE_LICENSE_APACHE2
  27. OWNERS
  28. perfetto.rc
  29. PRESUBMIT.py
  30. README.chromium
  31. README.md
  32. TEST_MAPPING
  33. traced_perf.rc
  34. WORKSPACE
README.md

Perfetto - Performance instrumentation and tracing

Perfetto is an open-source project for performance instrumentation and tracing of Linux/Android/Chrome platforms and user-space apps.

See www.perfetto.dev for docs.

Contributing

See /docs/contributing.md for instructions.

The source-of-truth repo is Android's Gerrit. The GitHub repo is a read-only mirror.

Bugs

  • For bugs affecting Android or the tracing internals use the internal bug tracker (go/perfetto-bugs).
  • For bugs affecting Chrome use http://crbug.com, Component:Speed>Tracing label:Perfetto.

Community

You can reach us on our Discord channel. If you prefer using IRC we have an experimental Discord <> IRC bridge synced with #perfetto-dev on Freenode.