Google Git
Sign in
flutter / third_party / perfetto / 964a32fada06a2501084ee0c2a9c3ece3e3ba52b
commit964a32fada06a2501084ee0c2a9c3ece3e3ba52b[log] [tgz]
authorDaniele Di Proietto <ddiproietto@google.com>Wed Feb 28 15:30:34 2024 +0000
committerDaniele Di Proietto <ddiproietto@google.com>Wed Feb 28 16:16:02 2024 +0000
tree57c8fa4f1650853cefedea2666775abc8bd71442
parent1f40922d0be39fee83dc4d180c63fedb1536cfa3 [diff]
Fix TraceBlob move assignment operator

There was a subtle bug in TraceBlob move assignment operator, where the
memory owned by this trace blob would be leaked.

Fix this, as suggested by Primiano, by explicitly implementing the move
constructor and using the move constructor from the move assignment
operator.

This was not an actual problem, nothing in the codebase calls TraceBlob.
I'm fixing it anyway because TraceBlob is part of the public interface.

Change-Id: Ia0bed4c89612470abc80ccbfd0df9ea3434c180b
5 files changed
tree: 57c8fa4f1650853cefedea2666775abc8bd71442
  1. .github/
  2. bazel/
  3. build_overrides/
  4. buildtools/
  5. debian/
  6. docs/
  7. examples/
  8. gn/
  9. include/
  10. infra/
  11. protos/
  12. python/
  13. src/
  14. test/
  15. third_party/
  16. tools/
  17. ui/
  18. .clang-format
  19. .clang-tidy
  20. .git-blame-ignore-revs
  21. .gitattributes
  22. .gitignore
  23. .gn
  24. .style.yapf
  25. Android.bp
  26. Android.bp.extras
  27. BUILD
  28. BUILD.extras
  29. BUILD.gn
  30. CHANGELOG
  31. codereview.settings
  32. DIR_METADATA
  33. heapprofd.rc
  34. LICENSE
  35. meson.build
  36. METADATA
  37. MODULE_LICENSE_APACHE2
  38. OWNERS
  39. perfetto.rc
  40. PerfettoIntegrationTests.xml
  41. PRESUBMIT.py
  42. README.chromium
  43. README.md
  44. TEST_MAPPING
  45. traced_perf.rc
  46. WATCHLISTS
  47. WORKSPACE
README.md

Perfetto - System profiling, app tracing and trace analysis

Perfetto is a production-grade open-source stack for performance instrumentation and trace analysis. It offers services and libraries and for recording system-level and app-level traces, native + java heap profiling, a library for analyzing traces using SQL and a web-based UI to visualize and explore multi-GB traces.

See https://perfetto.dev/docs or the /docs/ directory for documentation.