Google Git
Sign in
flutter / third_party / perfetto / ed2d8bd069f483a597b29353d01233f9c171971f
commited2d8bd069f483a597b29353d01233f9c171971f[log] [tgz]
authorAlexander Timin <altimin@chromium.org>Fri Sep 24 15:31:20 2021 +0100
committerAlexander Timin <altimin@chromium.org>Fri Sep 24 15:31:20 2021 +0100
tree7b972fc7c92cfbbeb55c49a35d8c5eb9e6612653
parentae2171b89cb3e49f73ff100fc1647a93048ca472 [diff]
[tracing] Fix combining untyped and typed args in TRACE_EVENT.

Fix the compilation of passing a typed argument to TRACE_EVENT macro
after and untyped one (i.e. TRACE_EVENT(..., "arg", "value",
TrackEvent::kFoo, foo);) discovered in crrev.com/c/3178983.

This patch refactores WriteTrackEventArgs to fix that (using a
forward-declaration of untyped version) and adds integration tests
covering both untyped-after-typed and typed-after-untyped scenarios.

R=eseckler@google.com
CC=hbolaria@google.com

Change-Id: I61d3a9da31f93af6c6e01f4e76e812682cbed59e
2 files changed
tree: 7b972fc7c92cfbbeb55c49a35d8c5eb9e6612653
  1. .github/
  2. bazel/
  3. build_overrides/
  4. buildtools/
  5. debian/
  6. docs/
  7. examples/
  8. gn/
  9. include/
  10. infra/
  11. protos/
  12. src/
  13. test/
  14. tools/
  15. ui/
  16. .clang-format
  17. .clang-tidy
  18. .gitattributes
  19. .gitignore
  20. .gn
  21. .style.yapf
  22. Android.bp
  23. Android.bp.extras
  24. BUILD
  25. BUILD.extras
  26. BUILD.gn
  27. CHANGELOG
  28. codereview.settings
  29. DIR_METADATA
  30. heapprofd.rc
  31. LICENSE
  32. meson.build
  33. METADATA
  34. MODULE_LICENSE_APACHE2
  35. OWNERS
  36. perfetto.rc
  37. PerfettoIntegrationTests.xml
  38. PRESUBMIT.py
  39. README.chromium
  40. README.md
  41. TEST_MAPPING
  42. traced_perf.rc
  43. WORKSPACE
README.md

Perfetto - System profiling, app tracing and trace analysis

Perfetto is a production-grade open-source stack for performance instrumentation and trace analysis. It offers services and libraries and for recording system-level and app-level traces, native + java heap profiling, a library for analyzing traces using SQL and a web-based UI to visualize and explore multi-GB traces.

See https://perfetto.dev/docs or the /docs/ directory for documentation.