commit afb72b56a18a9d7849b4f9d19bc2b13e33b23cc2
author Primiano Tucci <primiano@google.com> Tue Sep 25 09:37:24 2018 +0100
committer Primiano Tucci <primiano@google.com> Tue Sep 25 09:37:24 2018 +0100
tree f3bcb5e960295db279e2b48914b5370bcde2a852
parent ffad25ebc4db9b8f79824acf1109cbd9a0175edc

Rename producer methods to Start/StopDataSource

This is a pure rename with no functional changes.
This is in preparation for the fast-triggering
APIs described in the linked bug.

Bug: 116547201
Change-Id: Ie9d5d4793350c5e92acec5c805637db05e54e634

test/end_to_end_shared_memory_fuzzer.cc

diff --git a/test/end_to_end_shared_memory_fuzzer.cc b/test/end_to_end_shared_memory_fuzzer.cc
index 6d29512..7bd70b3 100644
--- a/test/end_to_end_shared_memory_fuzzer.cc
+++ b/test/end_to_end_shared_memory_fuzzer.cc
@@ -76,9 +76,8 @@
 
   void OnDisconnect() override {}
 
-  void CreateDataSourceInstance(
-      DataSourceInstanceID,
-      const DataSourceConfig& source_config) override {
+  void StartDataSource(DataSourceInstanceID,
+                       const DataSourceConfig& source_config) override {
     auto trace_writer = endpoint_->CreateTraceWriter(
         static_cast<BufferID>(source_config.target_buffer()));
     {
@@ -94,7 +93,7 @@
     trace_writer->Flush(on_produced_and_committed_);
   }
 
-  void TearDownDataSourceInstance(DataSourceInstanceID) override {}
+  void StopDataSource(DataSourceInstanceID) override {}
   void OnTracingSetup() override {}
   void Flush(FlushRequestID, const DataSourceInstanceID*, size_t) override {}
 

test/fake_producer.cc

diff --git a/test/fake_producer.cc b/test/fake_producer.cc
index 823759c..ae8ea07 100644
--- a/test/fake_producer.cc
+++ b/test/fake_producer.cc
@@ -57,9 +57,8 @@
   FAIL() << "Producer unexpectedly disconnected from the service";
 }
 
-void FakeProducer::CreateDataSourceInstance(
-    DataSourceInstanceID,
-    const DataSourceConfig& source_config) {
+void FakeProducer::StartDataSource(DataSourceInstanceID,
+                                   const DataSourceConfig& source_config) {
   PERFETTO_DCHECK_THREAD(thread_checker_);
   trace_writer_ = endpoint_->CreateTraceWriter(
       static_cast<BufferID>(source_config.target_buffer()));
@@ -75,7 +74,7 @@
   }
 }
 
-void FakeProducer::TearDownDataSourceInstance(DataSourceInstanceID) {
+void FakeProducer::StopDataSource(DataSourceInstanceID) {
   PERFETTO_DCHECK_THREAD(thread_checker_);
   trace_writer_.reset();
 }

test/fake_producer.h

diff --git a/test/fake_producer.h b/test/fake_producer.h
index b9101e7..cc55640 100644
--- a/test/fake_producer.h
+++ b/test/fake_producer.h
@@ -46,9 +46,9 @@
   // Producer implementation.
   void OnConnect() override;
   void OnDisconnect() override;
-  void CreateDataSourceInstance(DataSourceInstanceID,
-                                const DataSourceConfig& source_config) override;
-  void TearDownDataSourceInstance(DataSourceInstanceID) override;
+  void StartDataSource(DataSourceInstanceID,
+                       const DataSourceConfig& source_config) override;
+  void StopDataSource(DataSourceInstanceID) override;
   void OnTracingSetup() override;
   void Flush(FlushRequestID, const DataSourceInstanceID*, size_t) override;