commit b3a389d5c75278a6434e09e52cdefcc6fd65fba6
author Steve Golton <stevegolton@google.com> Mon Jul 10 11:03:17 2023 +0100
committer Steve Golton <stevegolton@google.com> Mon Jul 10 13:13:12 2023 +0000
tree f5edcbee8c8efe5409808007d80a25559a18fafe
parent a3f3fe8d3ecd8a59e225da8aebfb2f93ec224e60

Time & Duration refactor.

- Rename `TPTime` type to `time`.
- Rename `TPDuration` type to `duration`.
- Remove `TPTimestamp` type (in favour of `time`).
- Brand `time` type.
- Add `Time` and `Duration` static classes for functions that operate on
  time and duration types.
- Remove free functions like `toNs` and `fromNs`.

Change-Id: I7651b97e44ded76d23fe2f566da10690e80c47be

ui/src/frontend/thread_state_tab.ts

diff --git a/ui/src/frontend/thread_state_tab.ts b/ui/src/frontend/thread_state_tab.ts
index 50f2b1a..485b402 100644
--- a/ui/src/frontend/thread_state_tab.ts
+++ b/ui/src/frontend/thread_state_tab.ts
@@ -14,12 +14,12 @@
 
 import m from 'mithril';
 
-import {formatDurationShort, TPTime} from '../common/time';
+import {Duration, time} from '../common/time';
 import {raf} from '../core/raf_scheduler';
 
 import {Anchor} from './anchor';
 import {BottomTab, bottomTabRegistry, NewBottomTabArgs} from './bottom_tab';
-import {asTPTimestamp, SchedSqlId, ThreadStateSqlId} from './sql_types';
+import {SchedSqlId, ThreadStateSqlId} from './sql_types';
 import {
   getFullThreadName,
   getProcessName,
@@ -34,7 +34,7 @@
   ThreadStateRef,
 } from './thread_state';
 import {DetailsShell} from './widgets/details_shell';
-import {Duration} from './widgets/duration';
+import {DurationWidget} from './widgets/duration';
 import {GridLayout} from './widgets/grid_layout';
 import {Section} from './widgets/section';
 import {SqlRef} from './widgets/sql_ref';
@@ -157,11 +157,11 @@
         Tree,
         m(TreeNode, {
           left: 'Start time',
-          right: m(Timestamp, {ts: asTPTimestamp(state.ts)}),
+          right: m(Timestamp, {ts: state.ts}),
         }),
         m(TreeNode, {
           left: 'Duration',
-          right: m(Duration, {dur: state.dur}),
+          right: m(DurationWidget, {dur: state.dur}),
         }),
         m(TreeNode, {
           left: 'State',
@@ -187,7 +187,7 @@
 
   private renderState(
       state: string, cpu: number|undefined, id: SchedSqlId|undefined,
-      ts: TPTime): m.Children {
+      ts: time): m.Children {
     if (!state) {
       return null;
     }
@@ -228,7 +228,7 @@
     });
 
     const nameForNextOrPrev = (state: ThreadState) =>
-        `${state.state} for ${formatDurationShort(state.dur)}`;
+        `${state.state} for ${Duration.humanise(state.dur)}`;
     return m(
         Tree,
         this.relatedStates.waker && m(TreeNode, {
@@ -255,16 +255,15 @@
                 left: 'Woken threads',
               },
               this.relatedStates.wakee.map(
-                  (state) =>
-                      m(TreeNode, ({
-                          left: m(Timestamp, {
-                            ts: state.ts,
-                            display: `Start+${
-                                formatDurationShort(state.ts - startTs)}`,
-                          }),
-                          right:
-                              renderRef(state, getFullThreadName(state.thread)),
-                        })))),
+                  (state) => m(TreeNode, ({
+                                 left: m(Timestamp, {
+                                   ts: state.ts,
+                                   display: `Start+${
+                                       Duration.humanise(state.ts - startTs)}`,
+                                 }),
+                                 right: renderRef(
+                                     state, getFullThreadName(state.thread)),
+                               })))),
     );
   }