[ui] Fix missing tracks in shared permalinks.
When a permalink is loaded, the state is updated before plugins are
initialised. This results in track vnodes & components getting created
before plugins have a chance to register tracks.
For scrolling tracks, tracks are only attempted to be resolved once:
when the track component is constructed. When no track is present at
construct time, the track latches into a state where it shows "No such
track", regardless of whether a plugin registers the correct track later
on.
An elegant fix would be to always register the plugins before attempting
to render any track components, but there didn't seem like an easy way
to do this.
This CL patches the issue by attempting to resolve/create tracks every
DOM render cycle in TrackPanel::view(), until the panel is resolved.
Thus, tracks will appear as soon as they've been registered.
Change-Id: I18f5b8d54fa3bfcf8aab9580ee8a71dd2e76c7f6
diff --git a/ui/src/frontend/track_panel.ts b/ui/src/frontend/track_panel.ts
index b8020fc..8dffff1 100644
--- a/ui/src/frontend/track_panel.ts
+++ b/ui/src/frontend/track_panel.ts
@@ -345,8 +345,7 @@
private track: TrackLike|undefined;
private trackState: TrackState|undefined;
- constructor(vnode: m.CVnode<TrackPanelAttrs>) {
- super();
+ private tryLoadTrack(vnode: m.CVnode<TrackPanelAttrs>) {
const trackId = vnode.attrs.id;
const trackState = globals.state.tracks[trackId];
@@ -359,7 +358,11 @@
this.trackState = trackState;
}
- view() {
+ view(vnode: m.CVnode<TrackPanelAttrs>) {
+ if (!this.track) {
+ this.tryLoadTrack(vnode);
+ }
+
if (this.track === undefined || this.trackState === undefined) {
return m('div', 'No such track');
}
