commit bb3b66d486694c9984e76d38e3bd7ca525edfee2
author Ioannis Ilkos <ilkos@google.com> Mon May 31 21:32:10 2021 +0100
committer Ioannis Ilkos <ilkos@google.com> Mon May 31 21:32:10 2021 +0100
tree d9f3ede03909bed658650b6b493bb197f26015c6
parent b3f455e9edced2a776ddcb5a2cdf5ddcefa8776f

Do not spam error log for malformed traces

We already log a stat, there's not much value added by repeating the
invalid id msg

Change-Id: I44436957ce83111ac6beef0684ab0afb2cc1c4e5

src/trace_processor/importers/proto/heap_graph_tracker.cc

diff --git a/src/trace_processor/importers/proto/heap_graph_tracker.cc b/src/trace_processor/importers/proto/heap_graph_tracker.cc
index e9b400d..f4e4f70 100644
--- a/src/trace_processor/importers/proto/heap_graph_tracker.cc
+++ b/src/trace_processor/importers/proto/heap_graph_tracker.cc
@@ -580,7 +580,7 @@
                   current_type->field_name_ids[field_offset_in_cls++];
               auto it = sequence_state.interned_fields.find(field_id);
               if (it == sequence_state.interned_fields.end()) {
-                PERFETTO_ELOG("Invalid field id.");
+                PERFETTO_DLOG("Invalid field id.");
                 context_->storage->IncrementIndexedStats(
                     stats::heap_graph_malformed_packet,
                     static_cast<int>(sequence_state.current_upid));