ui: Various small manual fixes for eslint
- Fix a handful of non-breaking spaces which crept in
- Fix some miss-indented code
- Always reject with Error rather than a string
- Rename a snake_case variable to camelCase
- Remove multiline strings (e.g the ones that end with a \)
- eslint and clang-format disagree on the formatting of for loops where
some of the statements are missing. e.g.
for (let i = 0; ; ++i)
for (let i = 0; i<n;)
these are rare in the code base so replace them with:
for (let i = 0; /* no condition */; ++i)
for (let i = 0; i<n; /* no increment */)
Change-Id: I263220920c86f82f5b109fa4c4926d9f6c4bb8bc
diff --git a/ui/.eslintrc.js b/ui/.eslintrc.js
index cb6b47c..583fdbf 100644
--- a/ui/.eslintrc.js
+++ b/ui/.eslintrc.js
@@ -54,5 +54,11 @@
// construtor.
'no-array-constructor': 'off',
'@typescript-eslint/no-array-constructor': ['error'],
+
+ // We have a lot normal functions which are capitalised.
+ // TODO(hjd): Switch these to be lowercase and remove capIsNew.
+ // There are also some properties like: foo.factory these should
+ // stay.
+ 'new-cap': ['error', {'capIsNew': false, 'properties': false}]
},
};
