)]}'
{
  "commit": "cc28cbfb68ca983b08773039e2938d9f5d296584",
  "tree": "b6ba809002e4a6a2ce38a07f8d60c70a32941d31",
  "parents": [
    "1ba4ba601cc4489b167b06b16e767ba39a43fdbd"
  ],
  "author": {
    "name": "Ryan Savitski",
    "email": "rsavitski@google.com",
    "time": "Fri Nov 09 22:55:12 2018 +0000"
  },
  "committer": {
    "name": "Ryan Savitski",
    "email": "rsavitski@google.com",
    "time": "Fri Nov 09 22:57:39 2018 +0000"
  },
  "message": "Deflake TracingServiceImplTest.WriteIntoFileAndStopOnMaxSize.\n\nThe test was asserting the wrong properties and passing for the wrong reasons.\nIt independently checked that: (a) there\u0027s at least 10 packets in the file, (b)\na prefix of the test packets has the expected payloads (but not that all test\npackets are accounted for).\n\nWhat was happening in practice is that in the passing case, the 512 bytes were\nfilled with the 4 preamble packets (sync marker, clock snapshot, trace stats,\ntrace config), followed by 6 (out of 10 expected) test packets.\n\nThe test became flaky as that combined size of these 10 packets became very\nclose to 512 bytes in practice, s.t. sometimes the 6th test packet could not\nfit (-\u003e there would only be 9 packets in the file). A possible explanation of\nwhy the issue manifested as being timing dependent - varint encoding of\ntimestamps, slower test execution -\u003e over the threshold for fitting the 10th\npacket in 512 bytes.\n\nI\u0027ve decided to assert the number of preamble packets strictly (making this a bit of a\nchange-detector test), erring on the side of eager and obvious failures if someone\nchanges the preamble format significantly.\n\n(Credit for most of the debugging goes to Lalit)\n\nChange-Id: I13951dc4756d76327a1bbf611828fe5c91201700\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "5a0ca160c64174204c5da7e63f70caf10e404e36",
      "old_mode": 33188,
      "old_path": "src/tracing/core/service_impl_unittest.cc",
      "new_id": "77d49e5ad395d7e1dab049677db51082e6de0754",
      "new_mode": 33188,
      "new_path": "src/tracing/core/service_impl_unittest.cc"
    }
  ]
}