commit d4519a4fe3fcab1ccd90c0bb13a841331546d0d2
author Lalit Maganti <lalitm@google.com> Wed Oct 04 16:32:46 2023 +0100
committer Lalit Maganti <lalitm@google.com> Wed Oct 04 16:32:46 2023 +0100
tree 1aa6557b2783494a6e7c8c88e8920a91a6a45033
parent b029b290c1ad31e97128cd385586093fa1cc3211

tp: return an explicit error if we failed to build the flamegraph

Change-Id: Icd741f3b93d3aa7e748a819951e48b08f5d19a23

src/trace_processor/perfetto_sql/intrinsics/table_functions/experimental_flamegraph.cc

diff --git a/src/trace_processor/perfetto_sql/intrinsics/table_functions/experimental_flamegraph.cc b/src/trace_processor/perfetto_sql/intrinsics/table_functions/experimental_flamegraph.cc
index 9a87d07..73f4748 100644
--- a/src/trace_processor/perfetto_sql/intrinsics/table_functions/experimental_flamegraph.cc
+++ b/src/trace_processor/perfetto_sql/intrinsics/table_functions/experimental_flamegraph.cc
@@ -18,6 +18,7 @@
 
 #include <unordered_set>
 
+#include "perfetto/base/status.h"
 #include "perfetto/ext/base/string_splitter.h"
 #include "perfetto/ext/base/string_utils.h"
 
@@ -342,6 +343,10 @@
         context_->storage.get(), values.upid, values.upid_group,
         values.time_constraints);
   }
+  if (!table) {
+    return base::ErrStatus("Failed to build flamegraph");
+  }
+
   if (!values.focus_str.empty()) {
     table =
         FocusTable(context_->storage.get(), std::move(table), values.focus_str);