GN: avoid absolute paths and add PRESUBMIT
Absolute GN paths create problems when perfetto is embedded
in other projects (especially V8).
Sometimes they sneak in, mostly from new contributors.
This adds a PRESUBMIT that warns about it.
I fixed existing places and ran gn format on everything.
Change-Id: Ic3dd7747e3a6b5d4b59b8e46465d9c1f4146bcd4
diff --git a/BUILD.gn b/BUILD.gn
index a80de8d..bfadeca 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -98,7 +98,7 @@
test("perfetto_unittests") {
if (is_fuchsia) {
additional_manifest_fragments =
- [ "//build/config/fuchsia/test/network.shard.test-cml" ]
+ [ "//build/config/fuchsia/test/network.shard.test-cml" ] # nogncheck
}
deps = perfetto_unittests_targets
}
@@ -266,7 +266,7 @@
"src/tracing:platform_impl",
]
sources = [ "include/perfetto/tracing.h" ]
- assert_no_deps = [ "//gn:protobuf_lite" ]
+ assert_no_deps = [ "gn:protobuf_lite" ]
}
}
@@ -283,8 +283,8 @@
"src/tracing:platform_impl",
"src/tracing/core",
]
- configs -= [ "//build/config/compiler:chromium_code" ]
- configs += [ "//build/config/compiler:no_chromium_code" ]
+ configs -= [ "//build/config/compiler:chromium_code" ] # nogncheck
+ configs += [ "//build/config/compiler:no_chromium_code" ] # nogncheck
public_deps = [
"include/perfetto/ext/trace_processor/importers/memory_tracker",
"include/perfetto/ext/tracing/core",
@@ -332,15 +332,15 @@
target(libtrace_processor_target_type, "libtrace_processor") {
public_configs = [ "gn:public_config" ]
deps = [ "src/trace_processor:lib" ]
- configs -= [ "//build/config/compiler:chromium_code" ]
- configs += [ "//build/config/compiler:no_chromium_code" ]
+ configs -= [ "//build/config/compiler:chromium_code" ] # nogncheck
+ configs += [ "//build/config/compiler:no_chromium_code" ] # nogncheck
public_deps = [ "include/perfetto/trace_processor" ]
}
component("perfetto_test_support") {
testonly = true
public_configs = [ "gn:public_config" ]
- configs -= [ "//build/config/compiler:chromium_code" ]
- configs += [ "//build/config/compiler:no_chromium_code" ]
+ configs -= [ "//build/config/compiler:chromium_code" ] # nogncheck
+ configs += [ "//build/config/compiler:no_chromium_code" ] # nogncheck
public_deps = [ "include/perfetto/test:test_support" ]
deps = [ "src/tracing/test:test_support" ]
}
