commit d88300df55cbe74de32bc3079af00e7f696b00ba
author Lalit Maganti <lalitm@google.com> Mon May 15 13:54:51 2023 +0100
committer Lalit Maganti <lalitm@google.com> Mon May 15 13:54:51 2023 +0100
tree 6dced33229591d9bbe5a95bacf7646cda0aff8c9
parent 6d3ebebf66d19c917abc580a58b4978719e170a9

tp: refactor function registration to go through SqliteEngine

This CL changes all function registration to pass through SqliteEngine
rather than using free functions. This allows us to track what
functions are being registered.

Bug: 261195778
Change-Id: I2964cffee8e1d561ad0bf075978f22413ef29226

Android.bp

diff --git a/Android.bp b/Android.bp
index 849d43f..cd0bc9e 100644
--- a/Android.bp
+++ b/Android.bp
@@ -2062,6 +2062,7 @@
         ":perfetto_src_trace_processor_metatrace",
         ":perfetto_src_trace_processor_metrics_metrics",
         ":perfetto_src_trace_processor_prelude_functions_functions",
+        ":perfetto_src_trace_processor_prelude_functions_interface",
         ":perfetto_src_trace_processor_prelude_operators_operators",
         ":perfetto_src_trace_processor_prelude_table_functions_interface",
         ":perfetto_src_trace_processor_prelude_table_functions_table_functions",
@@ -10166,13 +10167,20 @@
         "src/trace_processor/prelude/functions/import.cc",
         "src/trace_processor/prelude/functions/layout_functions.cc",
         "src/trace_processor/prelude/functions/pprof_functions.cc",
-        "src/trace_processor/prelude/functions/register_function.cc",
         "src/trace_processor/prelude/functions/sqlite3_str_split.cc",
         "src/trace_processor/prelude/functions/stack_functions.cc",
         "src/trace_processor/prelude/functions/to_ftrace.cc",
     ],
 }
 
+// GN: //src/trace_processor/prelude/functions:interface
+filegroup {
+    name: "perfetto_src_trace_processor_prelude_functions_interface",
+    srcs: [
+        "src/trace_processor/prelude/functions/sql_function.cc",
+    ],
+}
+
 // GN: //src/trace_processor/prelude/functions:unittests
 filegroup {
     name: "perfetto_src_trace_processor_prelude_functions_unittests",
@@ -12060,6 +12068,7 @@
         ":perfetto_src_trace_processor_metrics_metrics",
         ":perfetto_src_trace_processor_metrics_unittests",
         ":perfetto_src_trace_processor_prelude_functions_functions",
+        ":perfetto_src_trace_processor_prelude_functions_interface",
         ":perfetto_src_trace_processor_prelude_functions_unittests",
         ":perfetto_src_trace_processor_prelude_operators_operators",
         ":perfetto_src_trace_processor_prelude_operators_unittests",
@@ -12746,6 +12755,7 @@
         ":perfetto_src_trace_processor_metatrace",
         ":perfetto_src_trace_processor_metrics_metrics",
         ":perfetto_src_trace_processor_prelude_functions_functions",
+        ":perfetto_src_trace_processor_prelude_functions_interface",
         ":perfetto_src_trace_processor_prelude_operators_operators",
         ":perfetto_src_trace_processor_prelude_table_functions_interface",
         ":perfetto_src_trace_processor_prelude_table_functions_table_functions",
@@ -12970,6 +12980,7 @@
         ":perfetto_src_trace_processor_metatrace",
         ":perfetto_src_trace_processor_metrics_metrics",
         ":perfetto_src_trace_processor_prelude_functions_functions",
+        ":perfetto_src_trace_processor_prelude_functions_interface",
         ":perfetto_src_trace_processor_prelude_operators_operators",
         ":perfetto_src_trace_processor_prelude_table_functions_interface",
         ":perfetto_src_trace_processor_prelude_table_functions_table_functions",