commit db0d1b0d2459e8a1efd6ed4b42c0e5f4f8375804
author Florian Mayer <fmayer@google.com> Tue Jul 07 15:54:47 2020 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Tue Jul 07 15:54:47 2020 +0000
tree 7bb5e322618df4edfdac59a1f8a4a597e851293a
parent 1c5e512582c81a41b2cf986aeb0a509ebeca0123
parent a249c2de17d9b6ca4328ea92af24dfc6df6b188f

Merge "Check for valid slice in UpdateThreadDeltasForSliceId."

src/trace_processor/storage/trace_storage.h

diff --git a/src/trace_processor/storage/trace_storage.h b/src/trace_processor/storage/trace_storage.h
index 8194658..7f2fd2a 100644
--- a/src/trace_processor/storage/trace_storage.h
+++ b/src/trace_processor/storage/trace_storage.h
@@ -161,7 +161,10 @@
     void UpdateThreadDeltasForSliceId(uint32_t slice_id,
                                       int64_t end_thread_timestamp_ns,
                                       int64_t end_thread_instruction_count) {
-      uint32_t row = *FindRowForSliceId(slice_id);
+      auto opt_row = FindRowForSliceId(slice_id);
+      if (!opt_row)
+        return;
+      uint32_t row = *opt_row;
       int64_t begin_ns = thread_timestamp_ns_[row];
       thread_duration_ns_[row] = end_thread_timestamp_ns - begin_ns;
       int64_t begin_ticount = thread_instruction_counts_[row];
@@ -222,7 +225,10 @@
     void UpdateThreadDeltasForSliceId(uint32_t slice_id,
                                       int64_t end_thread_timestamp_ns,
                                       int64_t end_thread_instruction_count) {
-      uint32_t row = *FindRowForSliceId(slice_id);
+      auto opt_row = FindRowForSliceId(slice_id);
+      if (!opt_row)
+        return;
+      uint32_t row = *opt_row;
       int64_t begin_ns = thread_timestamp_ns_[row];
       thread_duration_ns_[row] = end_thread_timestamp_ns - begin_ns;
       int64_t begin_ticount = thread_instruction_counts_[row];