Google Git
Sign in
flutter / third_party / perfetto / e348903832bf1e483908a1e002ec89795437a236
commite348903832bf1e483908a1e002ec89795437a236[log] [tgz]
authorRyan Savitski <rsavitski@google.com>Fri May 03 14:46:04 2024 +0100
committerRyan Savitski <rsavitski@google.com>Fri May 03 14:03:37 2024 +0000
tree8248278a924f8729cb7e36dd45a5749bd60c2b72
parent0618cd50b36961e43ccf6cc1cd8791c45c9f402e [diff]
tp: binder_tracker: fix performance issue due to insert/erase heavy workload + FlatHashMap

On a 10 minute trace with ~500k binder_transaction events, ~50% of the
trace parsing time is spent in binder_tracker due to a performance issue
in FlatHashMap. The map implementation never cleans tombstones outside
of a resize, so a heavy insert+erase workload degrades to full scans of
the hash map's capacity (since it becomes 100% full with tombstones).

For now, fix by switching to std::unordered_map. Myself and Primiano
will look into improving the hash table itself next week.

Change-Id: Iedca0e490e4a024fb59b84b485be250bd579f9d3
4 files changed
tree: 8248278a924f8729cb7e36dd45a5749bd60c2b72
  1. .github/
  2. bazel/
  3. build_overrides/
  4. buildtools/
  5. debian/
  6. docs/
  7. examples/
  8. gn/
  9. include/
  10. infra/
  11. protos/
  12. python/
  13. src/
  14. test/
  15. third_party/
  16. tools/
  17. ui/
  18. .clang-format
  19. .clang-tidy
  20. .git-blame-ignore-revs
  21. .gitattributes
  22. .gitignore
  23. .gn
  24. .style.yapf
  25. Android.bp
  26. Android.bp.extras
  27. BUILD
  28. BUILD.extras
  29. BUILD.gn
  30. CHANGELOG
  31. codereview.settings
  32. DIR_METADATA
  33. heapprofd.rc
  34. LICENSE
  35. meson.build
  36. METADATA
  37. MODULE_LICENSE_APACHE2
  38. OWNERS
  39. perfetto.rc
  40. PerfettoIntegrationTests.xml
  41. persistent_cfg.pbtxt
  42. PRESUBMIT.py
  43. README.chromium
  44. README.md
  45. TEST_MAPPING
  46. traced_perf.rc
  47. WATCHLISTS
  48. WORKSPACE
README.md

Perfetto - System profiling, app tracing and trace analysis

Perfetto is a production-grade open-source stack for performance instrumentation and trace analysis. It offers services and libraries and for recording system-level and app-level traces, native + java heap profiling, a library for analyzing traces using SQL and a web-based UI to visualize and explore multi-GB traces.

See https://perfetto.dev/docs or the /docs/ directory for documentation.