commit e97c89b20f184477c1624076fadb95aa25d69df5
author Hector Dearman <hjd@google.com> Fri Jan 08 13:00:13 2021 +0000
committer Hector Dearman <hjd@google.com> Wed Jan 13 12:24:30 2021 +0000
tree 54c588bff93ffcfbc0168a5a3bc67f413ed59f48
parent afc78f5e6ae999fd26a7473e8e2b068b6e666063

upkeep: Use empty() rather than size() == 0

This resolves some issues found by go/upkeep

Change-Id: I00135edbb5186c442088c77aac3a8f209644b597

src/trace_processor/trace_processor_shell.cc

diff --git a/src/trace_processor/trace_processor_shell.cc b/src/trace_processor/trace_processor_shell.cc
index e02225d..c2755a9 100644
--- a/src/trace_processor/trace_processor_shell.cc
+++ b/src/trace_processor/trace_processor_shell.cc
@@ -117,14 +117,14 @@
 
 std::string GetPerfettoPath() {
   std::string config = GetConfigPath();
-  if (config == "")
+  if (config.empty())
     return "";
   return config + "/perfetto";
 }
 
 std::string GetHistoryPath() {
   std::string perfetto = GetPerfettoPath();
-  if (perfetto == "")
+  if (perfetto.empty())
     return "";
   return perfetto + "/.trace_processor_shell_history";
 }
@@ -133,7 +133,7 @@
   linenoiseSetMultiLine(true);
   linenoiseHistorySetMaxLen(1000);
 
-  bool success = GetHistoryPath() != "";
+  bool success = !GetHistoryPath().empty();
   success = success && EnsureDir(GetConfigPath());
   success = success && EnsureDir(GetPerfettoPath());
   success = success && EnsureFile(GetHistoryPath());