[stdlib] Fix thread_executing_span runnable state
There was an incorrect SQL condition in the Runnable state view
Test: tools/diff_test_trace_processor.py out/android/trace_processor_shell --name-filter '.*TablesSched:.*'
Change-Id: If88daefb4d52525ad4533237909d77c9d16a2720
diff --git a/src/trace_processor/stdlib/experimental/thread_executing_span.sql b/src/trace_processor/stdlib/experimental/thread_executing_span.sql
index 44bac68..be94e25 100644
--- a/src/trace_processor/stdlib/experimental/thread_executing_span.sql
+++ b/src/trace_processor/stdlib/experimental/thread_executing_span.sql
@@ -42,7 +42,7 @@
thread_state.waker_utid
FROM thread_state
WHERE thread_state.dur != -1 AND thread_state.waker_utid IS NOT NULL
- AND thread_state.irq_context = 0 OR thread_state.irq_context IS NULL;
+ AND (thread_state.irq_context = 0 OR thread_state.irq_context IS NULL);
-- Similar to |internal_runnable_state| but finds the runnable states at thread fork.
CREATE VIEW internal_fork_runnable_state
diff --git a/test/trace_processor/diff_tests/tables/tests_sched.py b/test/trace_processor/diff_tests/tables/tests_sched.py
index 3314008..4235a0a 100644
--- a/test/trace_processor/diff_tests/tables/tests_sched.py
+++ b/test/trace_processor/diff_tests/tables/tests_sched.py
@@ -182,6 +182,18 @@
1735842081507,293868,3475,527,"shell svc 3474","/apex/com.android.adbd/bin/adbd","adbd","/apex/com.android.adbd/bin/adbd","[NULL]","[NULL]","[NULL]"
"""))
+ def test_thread_executing_span_internal_runnable_state_has_no_running(self):
+ return DiffTestBlueprint(
+ trace=DataPath('sched_wakeup_trace.atr'),
+ query="""
+ SELECT IMPORT('experimental.thread_executing_span');
+ SELECT COUNT(*) AS count FROM internal_runnable_state WHERE state = 'Running'
+ """,
+ out=Csv("""
+ "count"
+ 0
+ """))
+
def test_thread_executing_span_graph_has_no_null_dur(self):
return DiffTestBlueprint(
trace=DataPath('sched_wakeup_trace.atr'),
