)]}'
{
  "commit": "930ca43286e5c39519929c0717d136ed192ef552",
  "tree": "a9cae934a9728551f2681b06983f1a5cae7200ee",
  "parents": [
    "3b643a89e808ab0ebddf1241f92ba3d4c55b851a"
  ],
  "author": {
    "name": "Lalit Maganti",
    "email": "lalitmaganti@gmail.com",
    "time": "Tue Apr 28 02:28:25 2026 +0100"
  },
  "committer": {
    "name": "Lalit Maganti",
    "email": "lalitmaganti@gmail.com",
    "time": "Tue Apr 28 02:37:57 2026 +0100"
  },
  "message": "tp: delete the legacy PerfettoSqlPreprocessor\n\nWith trace_processor routing through the syntaqlite-driven macro path\n(see the previous CL), the handwritten preprocessor and the\nLegacyImpl/constexpr/optional\u003c\u003e machinery that gated its existence\nhave no remaining production callers.\n\n * Delete `src/trace_processor/perfetto_sql/preprocessor/` entirely\n   (~2.6k lines of generated grammar + handwritten preprocessor +\n   tests) and drop its BUILD.gn references from the parser, engine,\n   and root trace_processor targets.\n * Inline the real `Macro` struct on `PerfettoSqlParser` (was a\n   `using` alias to the preprocessor type) and drop the parser/engine\n   includes of the preprocessor header.\n * Collapse `PerfettoSqlParser::Impl` from the dual-impl wrapper into\n   the syntaqlite implementation directly: no more `LegacyImpl`,\n   `kUseSyntaqliteMacros`, `std::optional\u003c\u003e` slots, or `if constexpr`\n   dispatch.\n * Drop the `kBang` token alias added to SqliteTokenizer when the\n   legacy preprocessor needed to recognise `!` as a macro indicator.\n * Drop the `kUsesSyntaqliteMacros` test gate and the\n   ExpandsTokenApplyIntrinsic skip-on-legacy guard.\n * Refresh the engine.cc architecture comment to drop the\n   preprocessor layer from the diagram.\n\nAndroid.bp/BUILD regen happens at upload time via tools/gen_all per\nproject convention.\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "84c1265976f5dbe5cc5a02f0a293123e34509a96",
      "old_mode": 33188,
      "old_path": "Android.bp",
      "new_id": "2ca880c8b50ed88708c4360a3dfb5498964266f7",
      "new_mode": 33188,
      "new_path": "Android.bp"
    },
    {
      "type": "modify",
      "old_id": "66883d40f059936407d2b1d6c99adb1c3384dd7e",
      "old_mode": 33188,
      "old_path": "BUILD",
      "new_id": "52bcba4890c0954b6e69099f0e583138f493e88b",
      "new_mode": 33188,
      "new_path": "BUILD"
    },
    {
      "type": "modify",
      "old_id": "08d78ef455a82f28d1aacd5d82279e7234819246",
      "old_mode": 33188,
      "old_path": "src/trace_processor/BUILD.gn",
      "new_id": "d83d16a036ecfb0ec07c92b206671967ae1ab3c1",
      "new_mode": 33188,
      "new_path": "src/trace_processor/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "08ec5218824fbf4e67355730c15e2a73976dba5f",
      "old_mode": 33188,
      "old_path": "src/trace_processor/perfetto_sql/engine/perfetto_sql_engine.cc",
      "new_id": "25cb7f3ff0efd8093d44324714f8bf60f76ddb06",
      "new_mode": 33188,
      "new_path": "src/trace_processor/perfetto_sql/engine/perfetto_sql_engine.cc"
    },
    {
      "type": "modify",
      "old_id": "b3bb680ddd8e95f7e51bb77192cd98df643e1d86",
      "old_mode": 33188,
      "old_path": "src/trace_processor/perfetto_sql/parser/BUILD.gn",
      "new_id": "bdd9b25549102030636b791cf6b29ed164de0d10",
      "new_mode": 33188,
      "new_path": "src/trace_processor/perfetto_sql/parser/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "dc39c8d25b573e78ec3a8ce2f3d8bc7ad69471a2",
      "old_mode": 33188,
      "old_path": "src/trace_processor/perfetto_sql/parser/perfetto_sql_parser.cc",
      "new_id": "4bf82aa04df8389cb768b970090c4d686589597a",
      "new_mode": 33188,
      "new_path": "src/trace_processor/perfetto_sql/parser/perfetto_sql_parser.cc"
    },
    {
      "type": "modify",
      "old_id": "3414de7cb9182f5b26c9819314e6f8ee9608b938",
      "old_mode": 33188,
      "old_path": "src/trace_processor/perfetto_sql/parser/perfetto_sql_parser.h",
      "new_id": "7910eaef84eda1cadebcb1a550b4e03fd36438c2",
      "new_mode": 33188,
      "new_path": "src/trace_processor/perfetto_sql/parser/perfetto_sql_parser.h"
    },
    {
      "type": "modify",
      "old_id": "5a43b3afd3948b2615da7dd59687269ea9de7807",
      "old_mode": 33188,
      "old_path": "src/trace_processor/perfetto_sql/parser/perfetto_sql_parser_unittest.cc",
      "new_id": "644583f93e9f808a1871ae211a3cfec52da46013",
      "new_mode": 33188,
      "new_path": "src/trace_processor/perfetto_sql/parser/perfetto_sql_parser_unittest.cc"
    },
    {
      "type": "delete",
      "old_id": "43d074ecf60a3f6da2275cf393fcd8ec395412ba",
      "old_mode": 33188,
      "old_path": "src/trace_processor/perfetto_sql/preprocessor/.clang-format-ignore",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "delete",
      "old_id": "1f56c9d70555c3c08d39d92d25121c458a994b58",
      "old_mode": 33188,
      "old_path": "src/trace_processor/perfetto_sql/preprocessor/BUILD.gn",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "delete",
      "old_id": "71af92fad9098c4287d41d40012ef094ac5590f0",
      "old_mode": 33188,
      "old_path": "src/trace_processor/perfetto_sql/preprocessor/perfetto_sql_preprocessor.cc",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "delete",
      "old_id": "61032dc61025343b9ee417b747c925deeaff8a73",
      "old_mode": 33188,
      "old_path": "src/trace_processor/perfetto_sql/preprocessor/perfetto_sql_preprocessor.h",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "delete",
      "old_id": "eecba88dfa272fabffa6053f48a9f575052a4f54",
      "old_mode": 33188,
      "old_path": "src/trace_processor/perfetto_sql/preprocessor/perfetto_sql_preprocessor_unittest.cc",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "delete",
      "old_id": "0aae0644aba56d551edea7839e8850f979dbdbcf",
      "old_mode": 33188,
      "old_path": "src/trace_processor/perfetto_sql/preprocessor/preprocessor_grammar.c",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "delete",
      "old_id": "6cb021e3eb6e7bf4143a29221d092f40bbc269b5",
      "old_mode": 33188,
      "old_path": "src/trace_processor/perfetto_sql/preprocessor/preprocessor_grammar.h",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "delete",
      "old_id": "cdfa821d608b268ceedc811701852f1eeb595cdf",
      "old_mode": 33188,
      "old_path": "src/trace_processor/perfetto_sql/preprocessor/preprocessor_grammar.y",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "delete",
      "old_id": "c69f09574c03a024c6fe5e3e2654fab9e8cea684",
      "old_mode": 33188,
      "old_path": "src/trace_processor/perfetto_sql/preprocessor/preprocessor_grammar_interface.h",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "modify",
      "old_id": "8d023bf4a948e7c23aa906dee6d4d9e11e6f904e",
      "old_mode": 33188,
      "old_path": "src/trace_processor/perfetto_sql/tokenizer/sqlite_tokenizer.cc",
      "new_id": "b35f5ea0e3de0f10d37327616974a61ffe9c348f",
      "new_mode": 33188,
      "new_path": "src/trace_processor/perfetto_sql/tokenizer/sqlite_tokenizer.cc"
    },
    {
      "type": "modify",
      "old_id": "010b07a9e2bd8c26e032220f634d4e5e8f66ab28",
      "old_mode": 33188,
      "old_path": "src/trace_processor/perfetto_sql/tokenizer/sqlite_tokenizer.h",
      "new_id": "b6622b5cc8730ce72ff3070f5b2e048fa14b2505",
      "new_mode": 33188,
      "new_path": "src/trace_processor/perfetto_sql/tokenizer/sqlite_tokenizer.h"
    }
  ]
}