Google Git
Sign in
flutter / third_party / perfetto / aca6b9e9f1fabb971cf0dce1a75e50803ac25057
commitaca6b9e9f1fabb971cf0dce1a75e50803ac25057[log] [tgz]
authorPrimiano Tucci <primiano@google.com>Tue Jun 08 09:56:27 2021 +0100
committerPrimiano Tucci <primiano@google.com>Tue Jun 08 09:56:27 2021 +0100
tree13bfd00eda41ae4d2ec159164c3eaee6ee243926
parenteecd3dfe63a7fae7cba24afbb4e7e94f32fa9ad1 [diff]
TracedProto: Fix MSVC compilation (cpick on v16.x branch)

MSVC doesn't take too kindly to having multiple member functions with
the same signature, despite all but one not having a valid return type.
They should have been ignored due to SFINAE, but they aren't (more details here:
https://developercommunity.visualstudio.com/t/c-compiler-fails-sfinae-error-c2535/671364)

Switch the implementation of the TracedProtoWriter from multiple
SFINAE implementations of the same functions to partial specialisations
of a nested struct.

R=primiano@google.com,skyostil@google.com

Bug: b/189081318
(cherry picked from commit f3b2b64e53ba3e3b056e19636c94244301e60e3f)
Change-Id: I9fbf9fb9322fa1494f1f0ccf0d969b6c6b324354
2 files changed
tree: 13bfd00eda41ae4d2ec159164c3eaee6ee243926
  1. .github/
  2. bazel/
  3. build_overrides/
  4. buildtools/
  5. debian/
  6. docs/
  7. examples/
  8. gn/
  9. include/
  10. infra/
  11. protos/
  12. sdk/
  13. src/
  14. test/
  15. tools/
  16. ui/
  17. .clang-format
  18. .clang-tidy
  19. .gitattributes
  20. .gitignore
  21. .gn
  22. .style.yapf
  23. Android.bp
  24. Android.bp.extras
  25. BUILD
  26. BUILD.extras
  27. BUILD.gn
  28. CHANGELOG
  29. codereview.settings
  30. DIR_METADATA
  31. heapprofd.rc
  32. LICENSE
  33. meson.build
  34. METADATA
  35. MODULE_LICENSE_APACHE2
  36. OWNERS
  37. perfetto.rc
  38. PerfettoIntegrationTests.xml
  39. PRESUBMIT.py
  40. README.chromium
  41. README.md
  42. TEST_MAPPING
  43. traced_perf.rc
  44. WORKSPACE
README.md

Perfetto - System profiling, app tracing and trace analysis

Perfetto is a production-grade open-source stack for performance instrumentation and trace analysis. It offers services and libraries and for recording system-level and app-level traces, native + java heap profiling, a library for analyzing traces using SQL and a web-based UI to visualize and explore multi-GB traces.

See https://perfetto.dev/docs or the /docs/ directory for documentation.