Fix most of the unused variable warnings in Ruby tests (#5313)
* Fix most of the unused variable warnings in Ruby tests
* Add encoded_field_b back in tests/common_tests.rb
diff --git a/ruby/tests/common_tests.rb b/ruby/tests/common_tests.rb
index 920fadc..60897b6 100644
--- a/ruby/tests/common_tests.rb
+++ b/ruby/tests/common_tests.rb
@@ -204,10 +204,10 @@
m.optional_string = "asdf".encode!('UTF-8')
# Ruby 2.5 changed to raise FrozenError. However, assert_raise don't
# accept subclass.
- ok = true
+ ok = false
begin
m.optional_string.encode!('ASCII-8BIT')
- rescue RuntimeError => e
+ rescue RuntimeError
ok = true
end
assert ok
@@ -341,16 +341,16 @@
def test_rptfield_initialize
assert_raise ArgumentError do
- l = Google::Protobuf::RepeatedField.new
+ Google::Protobuf::RepeatedField.new
end
assert_raise ArgumentError do
- l = Google::Protobuf::RepeatedField.new(:message)
+ Google::Protobuf::RepeatedField.new(:message)
end
assert_raise ArgumentError do
- l = Google::Protobuf::RepeatedField.new([1, 2, 3])
+ Google::Protobuf::RepeatedField.new([1, 2, 3])
end
assert_raise ArgumentError do
- l = Google::Protobuf::RepeatedField.new(:message, [proto_module::TestMessage2.new])
+ Google::Protobuf::RepeatedField.new(:message, [proto_module::TestMessage2.new])
end
end
@@ -620,14 +620,14 @@
encoded_field_d = proto_module::OneofMessage.encode(proto_module::OneofMessage.new(:d => :B))
d3 = proto_module::OneofMessage.decode(
- encoded_field_c + encoded_field_a + encoded_field_d)
+ encoded_field_c + encoded_field_a + encoded_field_b + encoded_field_d)
assert d3.a == ""
assert d3.b == 0
assert d3.c == nil
assert d3.d == :B
d4 = proto_module::OneofMessage.decode(
- encoded_field_c + encoded_field_a + encoded_field_d +
+ encoded_field_c + encoded_field_a + encoded_field_b + encoded_field_d +
encoded_field_c)
assert d4.a == ""
assert d4.b == 0
@@ -800,7 +800,7 @@
m = proto_module::Recursive1.new(:foo => proto_module::Recursive2.new)
m.foo.foo = m
assert_raise RuntimeError do
- serialized = proto_module::Recursive1.encode(m)
+ proto_module::Recursive1.encode(m)
end
end
@@ -933,7 +933,6 @@
data = proto_module::TestMessage.encode(m)
- l = 0
10_000.times do
m = proto_module::TestMessage.decode(data)
data_new = proto_module::TestMessage.encode(m)
diff --git a/ruby/tests/encode_decode_test.rb b/ruby/tests/encode_decode_test.rb
index f8b991c..d2b25fd 100644
--- a/ruby/tests/encode_decode_test.rb
+++ b/ruby/tests/encode_decode_test.rb
@@ -86,7 +86,7 @@
end
def test_encode_wrong_msg
- e = assert_raise ::ArgumentError do
+ assert_raise ::ArgumentError do
m = A::B::C::TestMessage.new(
:optional_int32 => 1,
)
diff --git a/ruby/tests/generated_code_proto2_test.rb b/ruby/tests/generated_code_proto2_test.rb
index e988abd..302f945 100644
--- a/ruby/tests/generated_code_proto2_test.rb
+++ b/ruby/tests/generated_code_proto2_test.rb
@@ -14,8 +14,8 @@
# is to ensure that the output of the code generator is valid Ruby and
# successfully creates message definitions and classes, not to test every
# aspect of the extension (basic.rb is for that).
- m = A::B::Proto2::TestMessage.new()
- m2 = FooBar::Proto2::TestImportedMessage.new()
- m3 = A::B::Proto2::TestRubyPackageMessage.new()
+ A::B::Proto2::TestMessage.new
+ FooBar::Proto2::TestImportedMessage.new
+ A::B::Proto2::TestRubyPackageMessage.new
end
end
diff --git a/ruby/tests/generated_code_test.rb b/ruby/tests/generated_code_test.rb
index 431d681..6e6f915 100644
--- a/ruby/tests/generated_code_test.rb
+++ b/ruby/tests/generated_code_test.rb
@@ -14,8 +14,8 @@
# is to ensure that the output of the code generator is valid Ruby and
# successfully creates message definitions and classes, not to test every
# aspect of the extension (basic.rb is for that).
- m = A::B::C::TestMessage.new()
- m2 = FooBar::TestImportedMessage.new()
- m3 = A::B::TestRubyPackageMessage.new()
+ A::B::C::TestMessage.new
+ FooBar::TestImportedMessage.new
+ A::B::TestRubyPackageMessage.new
end
end
