commit 92e06d027c6c67d3fcd88e0f85d63a25fa197d9f
author Joshua Haberman <haberman@google.com> Mon Apr 25 09:52:40 2022 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Apr 25 09:53:10 2022 -0700
tree 5b8506b81f8529d5907a79d1bc2c4926a28fd036
parent 7f9135b766e16823e99f8b312b794ae27b1d4ee7

Fix for internal running of tests.

PiperOrigin-RevId: 444297087

python/descriptor_pool.c

diff --git a/python/descriptor_pool.c b/python/descriptor_pool.c
index 5a61b4e..b8ca06d 100644
--- a/python/descriptor_pool.c
+++ b/python/descriptor_pool.c
@@ -572,11 +572,18 @@
   size_t n;
   const upb_FieldDef** ext = upb_DefPool_GetAllExtensions(self->symtab, m, &n);
   PyObject* ret = PyList_New(n);
+  if (!ret) goto done;
   for (size_t i = 0; i < n; i++) {
     PyObject* field = PyUpb_FieldDescriptor_Get(ext[i]);
-    if (!field) return NULL;
+    if (!field) {
+      Py_DECREF(ret);
+      ret = NULL;
+      goto done;
+    }
     PyList_SetItem(ret, i, field);
   }
+done:
+  free(ext);
   return ret;
 }