commit a2ba8bc78e49b8b9053654030f5254fc38a7da93
author Mike Kruskal <mkruskal@google.com> Wed Oct 18 13:12:07 2023 -0700
committer Copybara-Service <copybara-worker@google.com> Wed Oct 18 13:15:50 2023 -0700
tree 703aaddfdfce04fd2ff221ec49d119cfa2c0f470
parent 898d8fa1fd6ff07149b283b3bbff00a6a3d8c52b

Enable conformance tests over editions protos

We transformed the proto2/proto3 protos to editions, and then run the same set of tests over both.  This will verify that migrating to editions preserves the same proto2/proto3 behavior.  These will not be enabled by default, and require a flag `--maximum_edition=2023`.

Future changes will:
- add more targeted editions-specific tests
- clean up our conformance test framework to allow for more targeted tests
- add wildcards to failure lists in limited cases to reduce noise
- add feature resolution conformance tests

PiperOrigin-RevId: 574570607

conformance/conformance_test.cc

diff --git a/conformance/conformance_test.cc b/conformance/conformance_test.cc
index 94efbcc..dbcaf45 100644
--- a/conformance/conformance_test.cc
+++ b/conformance/conformance_test.cc
@@ -149,6 +149,16 @@
       return "Proto3";
     case FileDescriptorLegacy::Syntax::SYNTAX_PROTO2:
       return "Proto2";
+    case FileDescriptorLegacy::Syntax::SYNTAX_EDITIONS: {
+      std::string id = "Editions";
+      if (prototype_message_.GetDescriptor()->name() == "TestAllTypesProto2") {
+        absl::StrAppend(&id, "_Proto2");
+      } else if (prototype_message_.GetDescriptor()->name() ==
+                 "TestAllTypesProto3") {
+        absl::StrAppend(&id, "_Proto3");
+      }
+      return id;
+    }
     default:
       return "Unknown";
   }