commit a734d12d61575e566ca35dde2470b19b8625ec79
author Jie Luo <jieluo@google.com> Thu Jul 06 14:22:36 2023 -0700
committer Copybara-Service <copybara-worker@google.com> Thu Jul 06 14:25:30 2023 -0700
tree 614a89ae92e4c8fbca7f659c32aacdd5c40f57d9
parent 0cb139cf9e497161909ef34f36d70106c87a844c

Use the default generated pool for some message factory tests.

Use the default generated pool for some message factory tests. Use a new descriptor
pool each time may turns out flake refleck test -- garbage collectors aren't
very predictable.

For blaze test third_party/py/google/protobuf/internal:message_factory_test_python_protos --runs_per_test_detects_flakes --runs_per_test=1000 --copt=-DPy_DEBUG

There were 30-50 failures before the change. Now tests are passing

PiperOrigin-RevId: 546091823

python/google/protobuf/internal/message_factory_test.py

diff --git a/python/google/protobuf/internal/message_factory_test.py b/python/google/protobuf/internal/message_factory_test.py
index 4b0f2f5..79c2343 100644
--- a/python/google/protobuf/internal/message_factory_test.py
+++ b/python/google/protobuf/internal/message_factory_test.py
@@ -122,7 +122,8 @@
       # Get messages should work when a file comes before its dependencies:
       # factory_test2_fd comes before factory_test1_fd.
       messages = message_factory.GetMessages([self.factory_test2_fd,
-                                              self.factory_test1_fd])
+                                              self.factory_test1_fd],
+                                             descriptor_pool.Default())
       self.assertTrue(
           set(['google.protobuf.python.internal.Factory2Message',
                'google.protobuf.python.internal.Factory1Message'],
@@ -256,17 +257,13 @@
         extendee='Container',
     )
 
-    class SimpleDescriptorDB:
-
-      def __init__(self, files):
-        self._files = files
-
-      def FindFileByName(self, name):
-        return self._files[name]
-
-    db = SimpleDescriptorDB({f1.name: f1, f2.name: f2, f3.name: f3})
-
-    pool = descriptor_pool.DescriptorPool(db)
+    pool = descriptor_pool.Default()
+    try:
+      pool.Add(f1)
+      pool.Add(f2)
+      pool.Add(f3)
+    except:
+      pass
     msgs = message_factory.GetMessageClassesForFiles(
         [f1.name, f3.name], pool)  # Deliberately not f2.
     msg = msgs['google.protobuf.python.internal.Container']
@@ -278,11 +275,24 @@
     m.Extensions[ext2].setting = 345
     serialized = m.SerializeToString()
 
-    pool = descriptor_pool.DescriptorPool(db)
+    f1.name='google/protobuf/internal/another/container.proto'
+    f1.package='google.protobuf.python.internal.another'
+    f2.name='google/protobuf/internal/another/value_type.proto'
+    f2.package='google.protobuf.python.internal.another'
+    f3.name='google/protobuf/internal/another/extension.proto'
+    f3.package='google.protobuf.python.internal.another'
+    f3.ClearField('dependency')
+    f3.dependency.extend([f1.name, f2.name])
+    try:
+      pool.Add(f1)
+      pool.Add(f2)
+      pool.Add(f3)
+    except:
+      pass
     msgs = message_factory.GetMessageClassesForFiles(
         [f1.name, f3.name], pool)  # Deliberately not f2.
-    msg = msgs['google.protobuf.python.internal.Container']
-    desc = msgs['google.protobuf.python.internal.Extension'].DESCRIPTOR
+    msg = msgs['google.protobuf.python.internal.another.Container']
+    desc = msgs['google.protobuf.python.internal.another.Extension'].DESCRIPTOR
     ext1 = desc.file.extensions_by_name['top_level_extension_field']
     ext2 = desc.extensions_by_name['nested_extension_field']
     m = msg.FromString(serialized)