commit a9625006c4a4cc6b38dd20ce5f90d6ac1472cb64
author Protobuf Team Bot <protobuf-github-bot@google.com> Tue Dec 06 22:06:21 2022 -0800
committer Copybara-Service <copybara-worker@google.com> Tue Dec 06 22:07:47 2022 -0800
tree 929344c27e52b0e948d1a855a6a4383ab91baa5e
parent 9d5dc6c9ec8c3db43407ad1d26d5889279d8a17e

Make proto allocation with Arenas faster

PiperOrigin-RevId: 493503091

src/google/protobuf/arena.h

diff --git a/src/google/protobuf/arena.h b/src/google/protobuf/arena.h
index abce219..ee41320 100644
--- a/src/google/protobuf/arena.h
+++ b/src/google/protobuf/arena.h
@@ -552,7 +552,7 @@
     static_assert(
         InternalHelper<T>::is_arena_constructable::value,
         "CreateMessage can only construct types that are ArenaConstructable");
-    if (arena == nullptr) {
+    if (PROTOBUF_PREDICT_FALSE(arena == nullptr)) {
       return new T(nullptr, static_cast<Args&&>(args)...);
     } else {
       return arena->DoCreateMessage<T>(static_cast<Args&&>(args)...);
@@ -642,7 +642,7 @@
     CreateInArenaStorageInternal(ptr, arena,
                                  typename is_arena_constructable<T>::type(),
                                  std::forward<Args>(args)...);
-    if (arena != nullptr) {
+    if (PROTOBUF_PREDICT_TRUE(arena != nullptr)) {
       RegisterDestructorInternal(
           ptr, arena,
           typename InternalHelper<T>::is_destructor_skippable::type());