commit b32938176dc841dd53e9712e1dd94472b32c27ba
author Protobuf Team Bot <protobuf-github-bot@google.com> Wed Apr 26 12:26:40 2023 -0700
committer Copybara-Service <copybara-worker@google.com> Wed Apr 26 12:27:26 2023 -0700
tree ee93a3041ad5a76009ed1597a8a03f8b7a9250b6
parent 22229bcaf9ebaa581900565722c568f10152584f

Delay defining Group constructor until after UnknownField is a complete type.

C++20 requires that types used in std::vector are complete. Group's constructor definition requires that UnknownFields' destructor be available, which means UnknownField must be complete.

PiperOrigin-RevId: 527341365

upb/util/compare_test.cc

diff --git a/upb/util/compare_test.cc b/upb/util/compare_test.cc
index e168f70..634f473 100644
--- a/upb/util/compare_test.cc
+++ b/upb/util/compare_test.cc
@@ -63,7 +63,7 @@
   uint32_t val;
 };
 struct Group {
-  Group(std::initializer_list<UnknownField> _val) : val(_val) {}
+  Group(std::initializer_list<UnknownField> _val);
   UnknownFields val;
 };
 
@@ -72,6 +72,8 @@
   std::variant<Varint, LongVarint, Delimited, Fixed64, Fixed32, Group> value;
 };
 
+Group::Group(std::initializer_list<UnknownField> _val) : val(_val) {}
+
 void EncodeVarint(uint64_t val, std::string* str) {
   do {
     char byte = val & 0x7fU;