)]}'
{
  "commit": "ba6da44dd0910910ea4aad90afc9ea0ae0afc9cf",
  "tree": "4bb9262767c6b00dc425f00eadb786349658ace8",
  "parents": [
    "5864b5078a0187a1a16d4d2ed6f55972511d0a94"
  ],
  "author": {
    "name": "zhangskz",
    "email": "sandyzhang@google.com",
    "time": "Mon Dec 02 12:17:12 2024 -0800"
  },
  "committer": {
    "name": "GitHub",
    "email": "noreply@github.com",
    "time": "Mon Dec 02 12:17:12 2024 -0800"
  },
  "message": "Rename maven to protobuf_maven in MODULE.bazel (#18641) (#19477)\n\nThe default name for the rules_jvm_external.maven rule is \"maven\". When not set, it defaults to \"maven\". For root modules also using rules_jvm_external, the name clash causes a warning:\r\n\r\n```\r\nDEBUG: $TMP/external/rules_jvm_external~/private/extensions/maven.bzl:154:14:\r\nThe maven repository \u0027maven\u0027 is used in two different bazel modules,\r\noriginally in \u0027\u003cmy_workspace\u003e\u0027 and now in \u0027protobuf\u0027\r\n```\r\n\r\nSummarizing @shs96c in [1]:\r\n\r\n\u003e The common maven repo name allows rulesets to contribute to the user\u0027s JARs.\r\n\u003e However, this implies that maven is for the end user, not for transitive\r\n\u003e dependencies. If a ruleset needs private dependencies, it should use a custom\r\n\u003e namespace rather than the maven namespace.\r\n\r\nSince protobuf is not contributing to user\u0027s JARs, we\u0027ll use a custom namespace. There\u0027s precedent for using a custom namespace for library modules:\r\n\r\n- rules_jvm_external uses `rules_jvm_external_deps` instead of `maven`.\r\n- rules_kotlin uses `kotlin_rules_maven` instead of `maven`.\r\n\r\n[1]: https://github.com/bazel-contrib/rules_jvm_external/issues/916#issuecomment-1645527584\r\n\r\nFixes #16839.\r\n\r\nCloses #18641\r\n\r\nCOPYBARA_INTEGRATE_REVIEW\u003dhttps://github.com/protocolbuffers/protobuf/pull/18641 from jschaf:joe/protobuf-maven bd2c62f3118264adc1e725102d1ecc576f145f35\r\nPiperOrigin-RevId: 684625084\r\n\r\nCo-authored-by: Joe Schafer \u003cjoe.schafer@delta46.us\u003e",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "4f4fa0fca787c2dbffdff1634942c8e79448783c",
      "old_mode": 33188,
      "old_path": "MODULE.bazel",
      "new_id": "a9a93ca1c95dae62039d3abf49c1bad20ed22ce8",
      "new_mode": 33188,
      "new_path": "MODULE.bazel"
    },
    {
      "type": "modify",
      "old_id": "dda7d44e5d6a5b1ccffbd5fc556fe09284039320",
      "old_mode": 33188,
      "old_path": "WORKSPACE",
      "new_id": "1652c799fdf5add015aa5252627ff74ffd86528c",
      "new_mode": 33188,
      "new_path": "WORKSPACE"
    },
    {
      "type": "modify",
      "old_id": "63b5f4af583a84e6a0845c5ddee543fe5866cf7c",
      "old_mode": 33188,
      "old_path": "java/core/BUILD.bazel",
      "new_id": "2d6cf2f8770ec2a7d2a2842502bb753704d43d2f",
      "new_mode": 33188,
      "new_path": "java/core/BUILD.bazel"
    },
    {
      "type": "modify",
      "old_id": "96958e986d232c44c4e2ff2941e556afcc9a2519",
      "old_mode": 33188,
      "old_path": "java/internal/BUILD.bazel",
      "new_id": "413360533c08ace958a4c6992b67cb3c395c7efe",
      "new_mode": 33188,
      "new_path": "java/internal/BUILD.bazel"
    },
    {
      "type": "modify",
      "old_id": "493ba1af911ccc868f313066680098f3f7f1651f",
      "old_mode": 33188,
      "old_path": "java/kotlin-lite/BUILD.bazel",
      "new_id": "8570268a14187a64a7ec845b7637938e1eebbde5",
      "new_mode": 33188,
      "new_path": "java/kotlin-lite/BUILD.bazel"
    },
    {
      "type": "modify",
      "old_id": "d0fe25fbb9aa1bf2161b6f7583ba243fcc07a353",
      "old_mode": 33188,
      "old_path": "java/kotlin/BUILD.bazel",
      "new_id": "1d9cb5f82d0ab17d50730c7550b2058bd9930bde",
      "new_mode": 33188,
      "new_path": "java/kotlin/BUILD.bazel"
    },
    {
      "type": "modify",
      "old_id": "f19cc38dd0a06be32b04b87f0702e79f692661d5",
      "old_mode": 33188,
      "old_path": "java/lite/BUILD.bazel",
      "new_id": "b4df648f6b6366edabf622faf51395aafc033596",
      "new_mode": 33188,
      "new_path": "java/lite/BUILD.bazel"
    },
    {
      "type": "modify",
      "old_id": "223e6fea733c893f0999b8f97c053e548e35862d",
      "old_mode": 33188,
      "old_path": "java/osgi/BUILD.bazel",
      "new_id": "0a9b210525d9e8d243aecbe4ad37fba7fabbf317",
      "new_mode": 33188,
      "new_path": "java/osgi/BUILD.bazel"
    },
    {
      "type": "modify",
      "old_id": "271bee1c10345e63a9e5c70e338bda0dd886290c",
      "old_mode": 33188,
      "old_path": "java/util/BUILD.bazel",
      "new_id": "c6ad3e5a37a74b35ca90b705be594a6fd838f472",
      "new_mode": 33188,
      "new_path": "java/util/BUILD.bazel"
    }
  ]
}