commit c38ba8d8bee7a80d5414e479bab1d9b541759d12
author Eric Salo <salo@google.com> Tue Oct 10 12:24:05 2023 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Oct 10 12:26:37 2023 -0700
tree 9f96c456baca4b6f00f5fb8a967c9144c2ef56bf
parent ec69a0af6378d12f162fdf4210c1692de2eb476d

upb: unroll a loop in upb_generator that only needs to iterate once

PiperOrigin-RevId: 572332570

upb_generator/protoc-gen-upb_minitable.cc

diff --git a/upb_generator/protoc-gen-upb_minitable.cc b/upb_generator/protoc-gen-upb_minitable.cc
index 3c6cd86..e3064ad 100644
--- a/upb_generator/protoc-gen-upb_minitable.cc
+++ b/upb_generator/protoc-gen-upb_minitable.cc
@@ -670,8 +670,9 @@
 }
 
 bool ParseOptions(Plugin* plugin) {
-  for (const auto& pair : ParseGeneratorParameter(plugin->parameter())) {
-    plugin->SetError(absl::Substitute("Unknown parameter: $0", pair.first));
+  const auto param = ParseGeneratorParameter(plugin->parameter());
+  if (!param.empty()) {
+    plugin->SetError(absl::Substitute("Unknown parameter: $0", param[0].first));
     return false;
   }