commit f5a01d1bbdb003e02fb32e1d4f5dffffdcae6bdf
author Thomas Van Lenten <thomasvl@google.com> Tue Apr 18 13:10:52 2017 -0400
committer Thomas Van Lenten <thomasvl@google.com> Tue Apr 18 13:10:52 2017 -0400
tree cfe6aceeba47e8d12293375c85f4fc8f2d31e66c
parent 8aa927f08f6b92808976b0c22fa4a45850279987

Tighten up class usage/checks.

- Ensure extensions resolution/wiring is happening directly on the
  messageClass (incase someone is doing odd things our out classes).
- Make the extension message check match the other class checks in
  for mergeFrom/isEqual/etc.

objectivec/GPBMessage.m

diff --git a/objectivec/GPBMessage.m b/objectivec/GPBMessage.m
index 78935b1..627a396 100644
--- a/objectivec/GPBMessage.m
+++ b/objectivec/GPBMessage.m
@@ -130,7 +130,7 @@
 
 static void CheckExtension(GPBMessage *self,
                            GPBExtensionDescriptor *extension) {
-  if ([self class] != extension.containingMessageClass) {
+  if (![self isKindOfClass:extension.containingMessageClass]) {
     [NSException
          raise:NSInvalidArgumentException
         format:@"Extension %@ used on wrong class (%@ instead of %@)",
@@ -3189,7 +3189,7 @@
 
 + (BOOL)resolveClassMethod:(SEL)sel {
   // Extensions scoped to a Message and looked up via class methods.
-  if (GPBResolveExtensionClassMethod(self, sel)) {
+  if (GPBResolveExtensionClassMethod([self descriptor].messageClass, sel)) {
     return YES;
   }
   return [super resolveClassMethod:sel];